Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Wenchao Xia
于 2012-9-3 22:20, Eric Blake 写道: On 09/03/2012 03:18 AM, Wenchao Xia wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files changed,

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Wenchao Xia
On Mon, Sep 3, 2012 at 9:18 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:10, Wenchao Xia ha scritto: + +/** + * QBlockInfoImageStatic: information about the block image. + * + * @loc: location info. + * @fmt_type: format type. + * @virt_size: virtual size in bytes. + * @backing_loc: backing file location, its type is QB_PROT_NONE if not

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Paolo Bonzini
Il 04/09/2012 09:19, Wenchao Xia ha scritto: +struct QBlockOption_prot_file { QBlockOptionProtFile +char *filename; 'const' There is a problem, this member would be used in information retrieving, so it will be set to a pointer to a string allocated at runtime, and later be

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-04 Thread Blue Swirl
On Tue, Sep 4, 2012 at 7:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/09/2012 09:19, Wenchao Xia ha scritto: +struct QBlockOption_prot_file { QBlockOptionProtFile +char *filename; 'const' There is a problem, this member would be used in information retrieving, so it will

[Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-03 Thread Wenchao Xia
This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files changed, 228 insertions(+), 0 deletions(-) create mode 100644 libqblock/libqblock-types.h

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-03 Thread Paolo Bonzini
Il 03/09/2012 11:18, Wenchao Xia ha scritto: +union QBlockOption_fmt { +struct QBlockOption_fmt_cow o_cow; +struct QBlockOption_fmt_qed o_qed; +struct QBlockOption_fmt_qcow o_qcow; +struct QBlockOption_fmt_qcow2 o_qcow2; +struct QBlockOption_fmt_raw

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-03 Thread Eric Blake
On 09/03/2012 03:18 AM, Wenchao Xia wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files changed, 228 insertions(+), 0

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-03 Thread Blue Swirl
On Mon, Sep 3, 2012 at 9:18 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch contains public type and defines used in APIs. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-types.h | 228 +++ 1 files

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-03 Thread Wenchao Xia
于 2012-9-3 21:13, Paolo Bonzini 写道: Il 03/09/2012 11:18, Wenchao Xia ha scritto: +union QBlockOption_fmt { +struct QBlockOption_fmt_cow o_cow; +struct QBlockOption_fmt_qed o_qed; +struct QBlockOption_fmt_qcow o_qcow; +struct QBlockOption_fmt_qcow2 o_qcow2; +