[Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Igor Mammedov
when CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based CPU at realize() time will keep current behavior after CPU features are converted to properties. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 11:11:02AM +0100, Igor Mammedov wrote: when CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based CPU at realize() time will keep current behavior after CPU features are converted to

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Igor Mammedov
On Tue, 11 Dec 2012 11:31:45 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Dec 11, 2012 at 11:11:02AM +0100, Igor Mammedov wrote: when CPU properties are implemented, ext2_features may change between object_new(CPU) and cpu_realize_fn(). Sanitizing ext2_features for AMD based

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Igor Mammedov
On Tue, 11 Dec 2012 11:31:45 -0200 Eduardo Habkost ehabk...@redhat.com wrote: [...] --- target-i386/cpu.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 63aae86..64b7637 100644 ---

Re: [Qemu-devel] [PATCH 2/6] target-i386: sanitize AMD's ext2_features at realize time

2012-12-11 Thread Eduardo Habkost
On Tue, Dec 11, 2012 at 03:08:56PM +0100, Igor Mammedov wrote: [...] +/* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits on + * CPUID[1].EDX. + */ +if (env-cpuid_vendor1 == CPUID_VENDOR_AMD_1 +env-cpuid_vendor2 == CPUID_VENDOR_AMD_2 +