Re: [Qemu-devel] [PATCH 21/29] target-sparc: allow 256M sized pages

2016-10-11 Thread Richard Henderson
On 10/01/2016 05:05 AM, Artyom Tarasenko wrote: +uint64_t mask = 1ULL + ~(8192ULL << 3 * TTE_PGSIZE(tlb->tte)); Not the first time it has appeared in this patch series, but I find the "1 + ~" idiom to be strange. Surely plain old "-" is clearer. r~

[Qemu-devel] [PATCH 21/29] target-sparc: allow 256M sized pages

2016-10-01 Thread Artyom Tarasenko
Signed-off-by: Artyom Tarasenko --- target-sparc/mmu_helper.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/target-sparc/mmu_helper.c b/target-sparc/mmu_helper.c index bef63f8..33b48eb 100644 --- a/target-sparc/mmu_helper.c +++