[Qemu-devel] [PATCH 27/56] vmsvga: add more fifo checks

[Michael Roth]

From: Gerd Hoffmann <kra...@redhat.com>

Make sure all fifo ptrs are within range.

Fixes: CVE-2016-4454
Cc: qemu-sta...@nongnu.org
Cc: P J P <ppan...@redhat.com>
Reported-by: 李强 <liqiang...@360.cn>
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
Message-id: 1464592161-18348-3-git-send-email-kra...@redhat.com
(cherry picked from commit c2e3c54d3960bc53bfa3a5ce7ea7a050b9be267e)
Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
---
 hw/display/vmware_vga.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 63a7c05..a26e62e 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -563,7 +563,10 @@ static inline int vmsvga_fifo_length(struct vmsvga_state_s 
*s)
     if (CMD(min) < (uint8_t *) s->cmd->fifo - (uint8_t *) s->fifo) {
         return 0;
     }
-    if (CMD(max) > SVGA_FIFO_SIZE) {
+    if (CMD(max) > SVGA_FIFO_SIZE ||
+        CMD(min) >= SVGA_FIFO_SIZE ||
+        CMD(stop) >= SVGA_FIFO_SIZE ||
+        CMD(next_cmd) >= SVGA_FIFO_SIZE) {
         return 0;
     }
     if (CMD(max) < CMD(min) + 10 * 1024) {
-- 
1.9.1