Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Vladimir Sementsov-Ogievskiy
01.08.2019 15:21, Max Reitz wrote: > On 01.08.19 14:02, Vladimir Sementsov-Ogievskiy wrote: >> 01.08.2019 14:37, Max Reitz wrote: >>> On 01.08.19 13:32, Vladimir Sementsov-Ogievskiy wrote: 01.08.2019 14:28, Max Reitz wrote: > On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: >>

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Max Reitz
On 01.08.19 14:02, Vladimir Sementsov-Ogievskiy wrote: > 01.08.2019 14:37, Max Reitz wrote: >> On 01.08.19 13:32, Vladimir Sementsov-Ogievskiy wrote: >>> 01.08.2019 14:28, Max Reitz wrote: On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: > 30.07.2019 21:28, John Snow wrote: >>

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Vladimir Sementsov-Ogievskiy
01.08.2019 14:37, Max Reitz wrote: > On 01.08.19 13:32, Vladimir Sementsov-Ogievskiy wrote: >> 01.08.2019 14:28, Max Reitz wrote: >>> On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: 30.07.2019 21:28, John Snow wrote: > > > On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Max Reitz
On 01.08.19 13:32, Vladimir Sementsov-Ogievskiy wrote: > 01.08.2019 14:28, Max Reitz wrote: >> On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: >>> 30.07.2019 21:28, John Snow wrote: On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > write flags are constant, let's

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Vladimir Sementsov-Ogievskiy
01.08.2019 14:28, Max Reitz wrote: > On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: >> 30.07.2019 21:28, John Snow wrote: >>> >>> >>> On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: write flags are constant, let's store it in BackupBlockJob instead of recalculating. It

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Max Reitz
On 31.07.19 18:01, Vladimir Sementsov-Ogievskiy wrote: > 30.07.2019 21:28, John Snow wrote: >> >> >> On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >>> write flags are constant, let's store it in BackupBlockJob instead of >>> recalculating. It also makes two boolean fields to be unused,

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-08-01 Thread Max Reitz
On 30.07.19 18:32, Vladimir Sementsov-Ogievskiy wrote: > write flags are constant, let's store it in BackupBlockJob instead of > recalculating. It also makes two boolean fields to be unused, so, > drop them. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 24

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-07-31 Thread Vladimir Sementsov-Ogievskiy
30.07.2019 21:28, John Snow wrote: > > > On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: >> write flags are constant, let's store it in BackupBlockJob instead of >> recalculating. It also makes two boolean fields to be unused, so, >> drop them. >> >> Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-07-30 Thread John Snow
On 7/30/19 12:32 PM, Vladimir Sementsov-Ogievskiy wrote: > write flags are constant, let's store it in BackupBlockJob instead of > recalculating. It also makes two boolean fields to be unused, so, > drop them. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 24

[Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags

2019-07-30 Thread Vladimir Sementsov-Ogievskiy
write flags are constant, let's store it in BackupBlockJob instead of recalculating. It also makes two boolean fields to be unused, so, drop them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 24 1 file changed, 12 insertions(+), 12 deletions(-)