Re: [Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

2017-12-11 Thread Anton Nefedov
On 8/12/2017 10:51 PM, John Snow wrote: Looks about right, just remember that this flow won't call block_acct_invalid because you're bypassing the return to ide_dma_cb. I assume you'll get to that in your next series. Yes; I meant to keep the trim accounting in ide_issue_trim_cb() For now,

Re: [Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

2017-12-08 Thread John Snow
On 12/08/2017 07:10 AM, Anton Nefedov wrote: > ATA8-ACS3, 7.9 DATA SET MANAGEMENT - 06h, DMA > > 7.9.5 Error Outputs > If the Trim bit is set to one and: > a) the device detects an invalid LBA Range Entry; or > b) count is greater than IDENTIFY DEVICE data word 105 >

[Qemu-devel] [PATCH 3/3] ide: abort TRIM operation for invalid range

2017-12-08 Thread Anton Nefedov
ATA8-ACS3, 7.9 DATA SET MANAGEMENT - 06h, DMA 7.9.5 Error Outputs If the Trim bit is set to one and: a) the device detects an invalid LBA Range Entry; or b) count is greater than IDENTIFY DEVICE data word 105 (see 7.16.7.55), then the device shall return command