Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-13 Thread Markus Armbruster
geoff--- via Qemu-devel writes: > On 2017-11-14 04:27, Markus Armbruster wrote: >> Ladi Prosek writes: >> >>> Adds a rollback path to ivshmem_enable_irqfd() and fixes >>> ivshmem_disable_irqfd() to bail if irqfd has not been enabled. >>> >>>

Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-13 Thread geoff--- via Qemu-devel
On 2017-11-14 04:27, Markus Armbruster wrote: Ladi Prosek writes: Adds a rollback path to ivshmem_enable_irqfd() and fixes ivshmem_disable_irqfd() to bail if irqfd has not been enabled. Signed-off-by: Ladi Prosek Is this a theoretical bug, or can

Re: [Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-13 Thread Markus Armbruster
Ladi Prosek writes: > Adds a rollback path to ivshmem_enable_irqfd() and fixes > ivshmem_disable_irqfd() to bail if irqfd has not been enabled. > > Signed-off-by: Ladi Prosek Is this a theoretical bug, or can you trigger it?

[Qemu-devel] [PATCH 3/3] ivshmem: Improve MSI irqfd error handling

2017-11-10 Thread Ladi Prosek
Adds a rollback path to ivshmem_enable_irqfd() and fixes ivshmem_disable_irqfd() to bail if irqfd has not been enabled. Signed-off-by: Ladi Prosek --- hw/misc/ivshmem.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git