Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 1 April 2014 18:26, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> The datasheet is clear that the frame length written to the DATA > >> register is actually stored in the TX FIFO; this means we don't

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 1 April 2014 18:45, Dr. David Alan Gilbert wrote: > > (resend reply - the mail gru got some of the 1st one) > > > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> > You should probably increment the migration state version number to 2.

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Peter Maydell
On 1 April 2014 18:45, Dr. David Alan Gilbert wrote: > (resend reply - the mail gru got some of the 1st one) > > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> > You should probably increment the migration state version number to 2. >> >> Oops, yes. > > Fix if you need to reroll, but not too

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
(resend reply - the mail gru got some of the 1st one) * Peter Maydell (peter.mayd...@linaro.org) wrote: > On 1 April 2014 18:26, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> The datasheet is clear that the frame length written to the DATA > >> register

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Peter Maydell
On 1 April 2014 18:26, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> The datasheet is clear that the frame length written to the DATA >> register is actually stored in the TX FIFO; this means we don't >> need to keep both tx_frame_len and tx_fifo_len state se

Re: [Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > The datasheet is clear that the frame length written to the DATA > register is actually stored in the TX FIFO; this means we don't > need to keep both tx_frame_len and tx_fifo_len state separately. > > Signed-off-by: Peter Maydell > --- > hw/ne

[Qemu-devel] [PATCH 3/5] hw/net/stellaris_enet: Rewrite tx fifo handling code

2014-04-01 Thread Peter Maydell
The datasheet is clear that the frame length written to the DATA register is actually stored in the TX FIFO; this means we don't need to keep both tx_frame_len and tx_fifo_len state separately. Signed-off-by: Peter Maydell --- hw/net/stellaris_enet.c | 119 +++