Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-13 Thread Michael S. Tsirkin
On Thu, Sep 13, 2018 at 05:20:34PM -0500, Brijesh Singh wrote: > > > On 09/13/2018 01:18 PM, Michael S. Tsirkin wrote: > ...>> > > > 0x01 00a0 00 00 48 > > > > > > Byte 0: 0x48 (special device) > > > Byte 1 & 2: must be zero > > > Byte 3: 0 (dte setting) > > > Byte 4: 0 (handle) > > > Byte

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-13 Thread Brijesh Singh
On 09/13/2018 01:18 PM, Michael S. Tsirkin wrote: ...>> 0x01 00a0 00 00 48 Byte 0: 0x48 (special device) Byte 1 & 2: must be zero Byte 3: 0 (dte setting) Byte 4: 0 (handle) Byte 5 & 6: IOAPIC devfn (14:0.0) Do you mean *bus* devfn? devfn is 0.0. Sorry my bad, I was meaning to write

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-13 Thread Michael S. Tsirkin
On Wed, Sep 12, 2018 at 02:24:52PM -0500, Brijesh Singh wrote: > > > On 09/12/2018 11:35 AM, Igor Mammedov wrote: > ... > > > > +/* > > > + * When interrupt remapping is enabled, Linux IOMMU driver also > > > checks > > > + * for special IVHD device (type IO-APIC), which is

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-12 Thread Peter Xu
On Wed, Sep 12, 2018 at 02:11:10PM -0500, Brijesh Singh wrote: > > > On 09/11/2018 11:35 PM, Peter Xu wrote: > > On Tue, Sep 11, 2018 at 11:49:47AM -0500, Brijesh Singh wrote: > > > When interrupt remapping is enabled, add a special IVHD device > > > (type IOAPIC) -- which is typically PCI

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-12 Thread Brijesh Singh
On 09/12/2018 11:35 AM, Igor Mammedov wrote: ... +/* + * When interrupt remapping is enabled, Linux IOMMU driver also checks + * for special IVHD device (type IO-APIC), which is typically presented + * as PCI device 14:00.0. Probably it shouldn't be a 'typically' device

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-12 Thread Brijesh Singh
On 09/11/2018 11:35 PM, Peter Xu wrote: On Tue, Sep 11, 2018 at 11:49:47AM -0500, Brijesh Singh wrote: When interrupt remapping is enabled, add a special IVHD device (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver checks for this special device. Cc: "Michael S.

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-12 Thread Igor Mammedov
On Tue, 11 Sep 2018 11:49:47 -0500 Brijesh Singh wrote: > When interrupt remapping is enabled, add a special IVHD device > (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver > checks for this special device. > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc: Richard

Re: [Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-11 Thread Peter Xu
On Tue, Sep 11, 2018 at 11:49:47AM -0500, Brijesh Singh wrote: > When interrupt remapping is enabled, add a special IVHD device > (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver > checks for this special device. > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc:

[Qemu-devel] [PATCH 4/6] i386: acpi: add IVHD device entry for IOAPIC

2018-09-11 Thread Brijesh Singh
When interrupt remapping is enabled, add a special IVHD device (type IOAPIC) -- which is typically PCI device 14:0.0. Linux IOMMU driver checks for this special device. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky