Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2021-03-15 Thread Philippe Mathieu-Daudé
On Tue, Dec 25, 2018 at 8:35 PM Richard Henderson wrote: > > Sorry I missed the original post, but: > > > +} else if (unlikely((XRb == 0) && (XRc == 0))) { > > +/* both operands zero registers -> just set destination to zero */ > > +tcg_gen_movi_i32(mxu_gpr[XRa - 1], 0); > > +

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-27 Thread Aleksandar Markovic
> From: Janeczek, Craig > > +/* return resulting byte to its original position */ > > +tcg_gen_shri_i32(t0, t0, 24); > > Should be a shift of 16 here > tcg_gen_shri_i32(t0, t0, 16); You are right, for this and the next three hints. Will be fixed in v2. Thanks, Aleksandar

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-27 Thread Janeczek, Craig via Qemu-devel
On 17.12.18. 21:04, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add translation handlers for max/min MXU instructions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 356 +--- > 1 file changed, 335 insertions(+), 21

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-25 Thread Richard Henderson
Sorry I missed the original post, but: > +} else if (unlikely((XRb == 0) && (XRc == 0))) { > +/* both operands zero registers -> just set destination to zero */ > +tcg_gen_movi_i32(mxu_gpr[XRa - 1], 0); > +} else if (unlikely((XRb == 0) || (XRc == 0))) { > +/*

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-23 Thread Aleksandar Markovic
On Mon, Dec 17, 2018 at 9:11 PM Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > Add translation handlers for max/min MXU instructions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 356 +--- > 1 file changed, 335

Re: [Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-18 Thread Stefan Markovic
On 17.12.18. 21:04, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add translation handlers for max/min MXU instructions. > > Signed-off-by: Aleksandar Markovic > --- > target/mips/translate.c | 356 +--- > 1 file changed, 335 insertions(+), 21

[Qemu-devel] [PATCH 5/6] target/mips: MXU: Add handlers for max/min instructions

2018-12-17 Thread Aleksandar Markovic
From: Aleksandar Markovic Add translation handlers for max/min MXU instructions. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 356 +--- 1 file changed, 335 insertions(+), 21 deletions(-) diff --git a/target/mips/translate.c