Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Peter Crosthwaite
On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini pbonz...@redhat.com wrote: It is never used, since ISA device are not hot-unpluggable. Is it not good design practice though for the uninit to be correctly implemented regardless of whether there is current-day usage? This seems like the kind of

Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:00, Peter Crosthwaite ha scritto: On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini pbonz...@redhat.com wrote: It is never used, since ISA device are not hot-unpluggable. Is it not good design practice though for the uninit to be correctly implemented regardless of whether

Re: [Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-31 Thread Peter Crosthwaite
On Thu, Jul 31, 2014 at 10:05 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 31/07/2014 14:00, Peter Crosthwaite ha scritto: On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini pbonz...@redhat.com wrote: It is never used, since ISA device are not hot-unpluggable. Is it not good design practice

[Qemu-devel] [PATCH 9/9] tpm_tis: remove instance_finalize callback

2014-07-30 Thread Paolo Bonzini
It is never used, since ISA device are not hot-unpluggable. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/tpm/tpm_tis.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index d398c16..82747ee 100644 --- a/hw/tpm/tpm_tis.c +++