Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Fei Li
On 11/29/2018 04:35 PM, Markus Armbruster wrote: Fei Li writes: On 11/28/2018 08:53 PM, Markus Armbruster wrote: Fei Li writes: When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with

Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-29 Thread Markus Armbruster
Fei Li writes: > On 11/28/2018 08:53 PM, Markus Armbruster wrote: >> Fei Li writes: >> >>> When qemu_signal_init() fails in qemu_init_main_loop(), we return >>> without setting an error. Its callers crash then when they try to >>> report the error with error_report_err(). >> Yes, that's a bug.

Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-28 Thread Fei Li
On 11/28/2018 08:53 PM, Markus Armbruster wrote: Fei Li writes: When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0.

Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-28 Thread Markus Armbruster
Fei Li writes: > When qemu_signal_init() fails in qemu_init_main_loop(), we return > without setting an error. Its callers crash then when they try to > report the error with error_report_err(). Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0. Has escaped notice since qemu_signalfd() is

[Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-28 Thread Fei Li
When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). To avoid such segmentation fault, add a new Error parameter to make the call trace to propagate the err to the final