Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-12-01 Thread peng.hao2
>On Wed, 28 Nov 2018 at 03:50, Peng Hao wrote: >> >> Prepare for pvpanic-mmio configure interface. >> >> Signed-off-by: Peng Hao >> --- >> hw/arm/sysbus-fdt.c | 2 ++ >> hw/arm/virt.c | 2 ++ >> hw/misc/pvpanic.c | 11 +-- >> 3 files changed, 13 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-30 Thread Peter Maydell
On Fri, 30 Nov 2018 at 16:14, Andrew Jones wrote: > > On Fri, Nov 30, 2018 at 03:57:13PM +, Peter Maydell wrote: > > On Fri, 30 Nov 2018 at 15:56, Peter Maydell > > wrote: > > > I suspect the reason you've done this is that you're > > > trying to get "-device pvpanic" to work on the command

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-30 Thread Andrew Jones
On Fri, Nov 30, 2018 at 03:57:13PM +, Peter Maydell wrote: > On Fri, 30 Nov 2018 at 15:56, Peter Maydell wrote: > > I suspect the reason you've done this is that you're > > trying to get "-device pvpanic" to work on the command > > line. I recommend not trying to get that to work. > > MMIO

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-30 Thread Peter Maydell
On Fri, 30 Nov 2018 at 15:56, Peter Maydell wrote: > I suspect the reason you've done this is that you're > trying to get "-device pvpanic" to work on the command > line. I recommend not trying to get that to work. > MMIO devices are not pluggable devices, and -device > is not expected to work

Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-30 Thread Peter Maydell
On Wed, 28 Nov 2018 at 03:50, Peng Hao wrote: > > Prepare for pvpanic-mmio configure interface. > > Signed-off-by: Peng Hao > --- > hw/arm/sysbus-fdt.c | 2 ++ > hw/arm/virt.c | 2 ++ > hw/misc/pvpanic.c | 11 +-- > 3 files changed, 13 insertions(+), 2 deletions(-) This looks

[Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

2018-11-27 Thread Peng Hao
Prepare for pvpanic-mmio configure interface. Signed-off-by: Peng Hao --- hw/arm/sysbus-fdt.c | 2 ++ hw/arm/virt.c | 2 ++ hw/misc/pvpanic.c | 11 +-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index