Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:56AM +0800, Wenchao Xia wrote: If it is not restored after qcow2_write_snapshots() fail, a core dump will happen in bdrv_close() since access of invalid pointer. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qcow2-snapshot.c |4 +++- 1

Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-09-30 Thread Eric Blake
On 09/08/2013 08:57 PM, Wenchao Xia wrote: If it is not restored after qcow2_write_snapshots() fail, a core dump will happen in bdrv_close() since access of invalid pointer. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qcow2-snapshot.c |4 +++- 1 files changed, 3

[Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-09-08 Thread Wenchao Xia
If it is not restored after qcow2_write_snapshots() fail, a core dump will happen in bdrv_close() since access of invalid pointer. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qcow2-snapshot.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git