Anthony Liguori aligu...@us.ibm.com writes:
mdroth mdr...@linux.vnet.ibm.com writes:
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote:
Gerd Hoffmann kra...@redhat.com writes:
Hi,
But why nested discriminators?
regular files: type=file
serial :
On 02/11/13 18:16, Markus Armbruster wrote:
Apropos chardev-add schema. I know I gave up whatever bikeshedding
privileges I might have by not reviewing the series before it went in,
but here goes anyway: I don't like the name ChardevPort. 'Port' tells
me nothing. It's really host character
[cc'ing Paolo]
Gerd Hoffmann kra...@redhat.com writes:
On 02/11/13 18:16, Markus Armbruster wrote:
Apropos chardev-add schema. I know I gave up whatever bikeshedding
privileges I might have by not reviewing the series before it went in,
but here goes anyway: I don't like the name
Il 12/02/2013 10:44, Markus Armbruster ha scritto:
Aside: 'type' is only there because we can't be bothered to figure out
the device type ourselves. Lame.
Is there any API for that, apart from shooting out random ioctls?
Now let's take another step back: a character device is just a file.
Hi,
Now let's take another step back: a character device is just a file.
Why can't we use plain ChardevFile for it?
It's not.
First, the file backend allows input and output being different files,
and the input file is optional. That doesn't make sense for the
parallel/serial port case.
Gerd Hoffmann kra...@redhat.com writes:
Hi,
But why nested discriminators?
regular files: type=file
serial : type=port, data.type=serial
parallel : type=port, data.type=parallel
Simpler, and closer to existing -chardev:
regular files: type=file
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote:
Gerd Hoffmann kra...@redhat.com writes:
Hi,
But why nested discriminators?
regular files: type=file
serial : type=port, data.type=serial
parallel : type=port, data.type=parallel
Gerd Hoffmann kra...@redhat.com writes:
Hi,
Now let's take another step back: a character device is just a file.
Why can't we use plain ChardevFile for it?
It's not.
A Unix character device is a special file.
First, the file backend allows input and output being different files,
and
Hi,
But why nested discriminators?
regular files: type=file
serial : type=port, data.type=serial
parallel : type=port, data.type=parallel
Simpler, and closer to existing -chardev:
regular files: type=file
serial : type=serial
parallel :
Applied. Thanks.
Regards,
Anthony Liguori
mdroth mdr...@linux.vnet.ibm.com writes:
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote:
Gerd Hoffmann kra...@redhat.com writes:
Hi,
But why nested discriminators?
regular files: type=file
serial : type=port, data.type=serial
parallel
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qapi-schema.json | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 736f881..bd289ae 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3152,6 +3152,9 @@
#
# Return
On 02/11/2013 10:05 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qapi-schema.json | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt
Apropos chardev-add schema. I know I gave up whatever bikeshedding
privileges I might have by not reviewing the series before it went in,
but here goes anyway: I don't like the name ChardevPort. 'Port' tells
me nothing. It's really host character device passthrough, isn't it,
Gerd?
Is it too
On 02/11/2013 10:16 AM, Markus Armbruster wrote:
Apropos chardev-add schema. I know I gave up whatever bikeshedding
privileges I might have by not reviewing the series before it went in,
but here goes anyway: I don't like the name ChardevPort. 'Port' tells
me nothing. It's really host
15 matches
Mail list logo
