Re: [Qemu-devel] [PATCH for-1.7] vga: fix invalid read after free

2013-11-05 Thread Gerd Hoffmann
On Di, 2013-11-05 at 16:15 +0100, Marc-André Lureau wrote: > --- a/hw/display/vga.c > +++ b/hw/display/vga.c > @@ -1707,7 +1707,6 @@ static void vga_draw_graphic(VGACommonState *s, > int full_update) > } else if (is_buffer_shared(surface) && > (full_update || surface_data(surfa

[Qemu-devel] [PATCH for-1.7] vga: fix invalid read after free

2013-11-05 Thread Marc-André Lureau
After calling dpy_gfx_replace_surface(s->con, surface), the outer surface is invalid. ==5370== Invalid read of size 4 ==5370==at 0x460229: surface_bits_per_pixel (console.h:250) ==5370==by 0x466A81: get_depth_index (vga.c:1173) ==5370==by 0x467EC2: vga_draw_graphic (vga.c:1718) ==5370=