Re: [Qemu-devel] [PATCH for-3.1] linux-user/sparc/signal.c: Remove dead code

2018-11-15 Thread Peter Maydell
On 15 November 2018 at 11:59, Laurent Vivier wrote: > On 15/11/2018 12:46, Peter Maydell wrote: >> Coverity complains (CID 1390847) about some dead code in >> do_sigreturn(). This is an if (err) clause that can never be >> true, copied from the kernel (where __get_user returns an error). >> The

Re: [Qemu-devel] [PATCH for-3.1] linux-user/sparc/signal.c: Remove dead code

2018-11-15 Thread Laurent Vivier
On 15/11/2018 12:46, Peter Maydell wrote: > Coverity complains (CID 1390847) about some dead code in > do_sigreturn(). This is an if (err) clause that can never be > true, copied from the kernel (where __get_user returns an error). > The one code path that could report an error is in the >

[Qemu-devel] [PATCH for-3.1] linux-user/sparc/signal.c: Remove dead code

2018-11-15 Thread Peter Maydell
Coverity complains (CID 1390847) about some dead code in do_sigreturn(). This is an if (err) clause that can never be true, copied from the kernel (where __get_user returns an error). The one code path that could report an error is in the currently commented-out pseudocode for handling FPU