Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread David Gibson
On Wed, Jul 04, 2018 at 09:42:16AM -0400, Programmingkid wrote: > > > On Jul 3, 2018, at 11:31 PM, David Gibson > > wrote: > > > > On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote: > >> Beginning with John Arbuckle's fdiv test case, clean up some > >> of the fp helpers. As

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Programmingkid writes: >> On Jul 4, 2018, at 11:39 AM, Alex Bennée wrote: >> >> >> Programmingkid writes: >> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: Richard Henderson writes: > > Anyway, all of this has been broken long enough that it'll need to

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 4, 2018, at 11:39 AM, Alex Bennée wrote: > > > Programmingkid writes: > >>> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: >>> >>> >>> Richard Henderson writes: >>> Anyway, all of this has been broken long enough that it'll need to wait til next devel cycle

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Programmingkid writes: >> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: >> >> >> Richard Henderson writes: >> >>> >>> Anyway, all of this has been broken long enough that it'll need to >>> wait til next devel cycle before anything further gets done. >> >> When it gets done should we add

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 4, 2018, at 10:15 AM, Alex Bennée wrote: > > > Richard Henderson writes: > >> >> Anyway, all of this has been broken long enough that it'll need to >> wait til next devel cycle before anything further gets done. > > When it gets done should we add some explicit ppc tests to

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Alex Bennée
Richard Henderson writes: > > Anyway, all of this has been broken long enough that it'll need to > wait til next devel cycle before anything further gets done. When it gets done should we add some explicit ppc tests to tests/tcg/ppc like we did with arm64 fcvt or would it be worth spending

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-04 Thread Programmingkid
> On Jul 3, 2018, at 11:31 PM, David Gibson wrote: > > On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote: >> Beginning with John Arbuckle's fdiv test case, clean up some >> of the fp helpers. As with fdiv, fre and fresqrt are missing >> divide-by-zero exceptions. >> >> I've

Re: [Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-03 Thread David Gibson
On Tue, Jul 03, 2018 at 08:17:25AM -0700, Richard Henderson wrote: > Beginning with John Arbuckle's fdiv test case, clean up some > of the fp helpers. As with fdiv, fre and fresqrt are missing > divide-by-zero exceptions. > > I've also noticed that load/store were using arithmetic conversions >

[Qemu-devel] [PATCH for-3.1 0/7] target/ppc fp cleanups

2018-07-03 Thread Richard Henderson
Beginning with John Arbuckle's fdiv test case, clean up some of the fp helpers. As with fdiv, fre and fresqrt are missing divide-by-zero exceptions. I've also noticed that load/store were using arithmetic conversions to/from float32. These should be using the non-arithmetic algorithms listed in