Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:21:36 +0100, a ecrit: > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-15 Thread Paolo Bonzini
On 14/11/2018 13:36, Marc-André Lureau wrote: > Only slirp/libslirp.h should be included. > > Instead of using some slirp declarations and utility functions directly, > let's copy them in net/util.h. > > Signed-off-by: Marc-André Lureau > --- > net/colo.h| 3 +-- > net/util.h

Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-14 Thread Philippe Mathieu-Daudé
On 14/11/18 13:36, Marc-André Lureau wrote: Only slirp/libslirp.h should be included. Instead of using some slirp declarations and utility functions directly, let's copy them in net/util.h. Nice cleanup! Can this single patch be applied out of this RFC series? Signed-off-by: Marc-André

[Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-14 Thread Marc-André Lureau
Only slirp/libslirp.h should be included. Instead of using some slirp declarations and utility functions directly, let's copy them in net/util.h. Signed-off-by: Marc-André Lureau --- net/colo.h| 3 +-- net/util.h| 55 +++