Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-30 Thread Stefan Weil
Am 17.08.2012 16:10, schrieb Jan Kiszka: On 2012-08-17 15:50, Stefan Weil wrote: ccc-analyzer reports this warning: console.c:1090:29: warning: Dereference of null pointer if (active_console-cursor_timer) { ^ Function console_select allows

Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-30 Thread Anthony Liguori
Stefan Weil s...@weilnetz.de writes: Am 17.08.2012 16:10, schrieb Jan Kiszka: On 2012-08-17 15:50, Stefan Weil wrote: ccc-analyzer reports this warning: console.c:1090:29: warning: Dereference of null pointer if (active_console-cursor_timer) { ^

[Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-17 Thread Stefan Weil
ccc-analyzer reports this warning: console.c:1090:29: warning: Dereference of null pointer if (active_console-cursor_timer) { ^ Function console_select allows active_console to be NULL, but would crash when accessing cursor_timer. Fix this. Signed-off-by:

Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-17 Thread Jan Kiszka
On 2012-08-17 15:50, Stefan Weil wrote: ccc-analyzer reports this warning: console.c:1090:29: warning: Dereference of null pointer if (active_console-cursor_timer) { ^ Function console_select allows active_console to be NULL, but would crash when