Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Palmer Dabbelt
On Wed, 27 Mar 2019 11:52:53 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 11:51 AM Alistair Francis wrote: Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis I dropped

Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Philippe Mathieu-Daudé
Le mer. 27 mars 2019 19:57, Alistair Francis a écrit : > Instead of using error_report() to print guest errors let's use > qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. > > Signed-off-by: Alistair Francis > --- > hw/riscv/sifive_plic.c | 12 +--- > 1 file changed, 9

[Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Alistair Francis
Instead of using error_report() to print guest errors let's use qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/riscv/sifive_plic.c

Re: [Qemu-devel] [PATCH for 4.0 v2 2/2] riscv: plic: Log guest errors

2019-03-27 Thread Alistair Francis
On Wed, Mar 27, 2019 at 11:51 AM Alistair Francis wrote: > > Instead of using error_report() to print guest errors let's use > qemu_log_mask(LOG_GUEST_ERROR,...) to log the error. > > Signed-off-by: Alistair Francis I dropped Philippe's review in this series. This should be included from v1: