Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread Laurent Vivier
Le 6 janvier 2014 à 02:57, André Hentschel n...@dawncrow.de a écrit : From: André Hentschel n...@dawncrow.de Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: André Hentschel n...@dawncrow.de [...] diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index cf08db5..b36f99c

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread Peter Maydell
On 6 January 2014 08:45, Laurent Vivier laur...@vivier.eu wrote: Le 6 janvier 2014 à 02:57, André Hentschel n...@dawncrow.de a écrit : diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index cf08db5..b36f99c 100644 --- a/linux-user/syscall_defs.h +++

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread Laurent Vivier
Le 6 janvier 2014 à 10:14, Peter Maydell peter.mayd...@linaro.org a écrit : On 6 January 2014 08:45, Laurent Vivier laur...@vivier.eu wrote: Le 6 janvier 2014 à 02:57, André Hentschel n...@dawncrow.de a écrit : diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread André Hentschel
This looks ok, except that scripts/checkpatch.pl says: WARNING: braces {} are necessary for all arms of this statement #36: FILE: linux-user/syscall.c:2254: +if (get_user_ual(sockfd, vptr) [...] total: 0 errors, 1 warnings, 30 lines checked Fix that and

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-06 Thread Peter Maydell
On 6 January 2014 15:38, André Hentschel n...@dawncrow.de wrote: This warning seems wrong: - the if statement has no braces and only one arm - the if statement looks like the others around it, i just try to keep the same style The warning is saying that you need braces. all arms for an

[Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-05 Thread André Hentschel
From: André Hentschel n...@dawncrow.de Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: André Hentschel n...@dawncrow.de --- See https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/net.h for the values. Not entirely sure how to implement recvmmsg and

Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall

2014-01-05 Thread Erik de Castro Lopo
Hi André, This looks ok, except that scripts/checkpatch.pl says: WARNING: braces {} are necessary for all arms of this statement #36: FILE: linux-user/syscall.c:2254: +if (get_user_ual(sockfd, vptr) [...] total: 0 errors, 1 warnings, 30 lines checked Fix that