Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread M. Mohan Kumar
Michael Tokarev m...@tls.msk.ru writes: 11.06.2013 00:47, Michael Tokarev wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Peter Maydell
On 11 June 2013 10:22, M. Mohan Kumar mo...@in.ibm.com wrote: I tried ./configure --disable-system --enable-virtfs and make. But didnt face any build failure. Could you please share your build failure information? virtfs-proxy-helper.1 is created inside the fsdev folder. Michael wrote The

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 13:22, M. Mohan Kumar wrote: Michael Tokarev m...@tls.msk.ru writes: 11.06.2013 00:47, Michael Tokarev wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 01:45, Peter Maydell wrote: On 10 June 2013 21:47, Michael Tokarev m...@tls.msk.ru wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Peter Maydell
On 11 June 2013 13:29, Michael Tokarev m...@tls.msk.ru wrote: 11.06.2013 01:45, Peter Maydell wrote: This doesn't feel to me like it's quite the right way to fix this bug. The current code in configure seems to tangle up (a) was virtfs requested and can we do it? with (b) what do we need to

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread M. Mohan Kumar
Peter Maydell peter.mayd...@linaro.org writes: How about this approach? [PATCH] configure: Disable virtfs if softmmu not enabled Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- configure | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 21:23, M. Mohan Kumar wrote: Peter Maydell peter.mayd...@linaro.org writes: How about this approach? Well, this is definitely wrong :) -if test $softmmu = yes ; then - if test $virtfs != no ; then + +if test $virtfs != no ; then + if test $softmmu = yes ; then if test

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Peter Maydell
On 11 June 2013 19:19, Michael Tokarev m...@tls.msk.ru wrote: FWIW, I still don't understand what Peter Maydell dislikes in a simplest case I posted initially, where we merely ignore (disable) virtfs in case !softmmu. It just seems to me that rather than fixing a bug in the makefile (it still

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread Michael Tokarev
11.06.2013 23:21, Peter Maydell пишет: On 11 June 2013 19:19, Michael Tokarev m...@tls.msk.ru wrote: FWIW, I still don't understand what Peter Maydell dislikes in a simplest case I posted initially, where we merely ignore (disable) virtfs in case !softmmu. It just seems to me that rather

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-11 Thread M. Mohan Kumar
Michael Tokarev m...@tls.msk.ru writes: 11.06.2013 21:23, M. Mohan Kumar wrote: Peter Maydell peter.mayd...@linaro.org writes: How about this approach? Well, this is definitely wrong :) -if test $softmmu = yes ; then - if test $virtfs != no ; then + +if test $virtfs != no ; then +

[Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper manpage (but not the executable). Cc: qemu-triv...@nongnu.org Cc: M.

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Michael Tokarev
11.06.2013 00:47, Michael Tokarev wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper manpage (but not the

Re: [Qemu-devel] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no

2013-06-10 Thread Peter Maydell
On 10 June 2013 21:47, Michael Tokarev m...@tls.msk.ru wrote: Or else ./configure --disable-system --enable-virtfs (which makes no sense by its own but does not error out) will fail to build, because it will define CONFIG_VIRTFS, and the makefile will try to build virtfs-proxy-helper