Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-29 Thread David Hildenbrand
>> Problem David tries to solve is that > > Uh, which David? I assume he was referring to you :) > >> 1: user hotplugged backend with wrong page size >> 2: hotplug of associated device 'pc-dimm' cleanly fails with error >> 3: guest does reboot and QEMU crashes with fatal error >> >> Issue

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-28 Thread David Gibson
On Thu, Mar 28, 2019 at 12:39:24PM +0100, Igor Mammedov wrote: > On Thu, 28 Mar 2019 11:18:02 +0100 > David Hildenbrand wrote: > > > On 28.03.19 01:24, David Gibson wrote: > > > On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: > > >> On 27.03.19 17:45, Igor Mammedov wrote:

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-28 Thread David Gibson
On Thu, Mar 28, 2019 at 11:18:02AM +0100, David Hildenbrand wrote: > On 28.03.19 01:24, David Gibson wrote: > > On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: > >> On 27.03.19 17:45, Igor Mammedov wrote: > >>> On Wed, 27 Mar 2019 14:59:44 +0100 > >>> David Hildenbrand wrote: >

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-28 Thread Igor Mammedov
On Thu, 28 Mar 2019 11:18:02 +0100 David Hildenbrand wrote: > On 28.03.19 01:24, David Gibson wrote: > > On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: > >> On 27.03.19 17:45, Igor Mammedov wrote: > >>> On Wed, 27 Mar 2019 14:59:44 +0100 > >>> David Hildenbrand wrote: >

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-28 Thread David Hildenbrand
On 28.03.19 01:24, David Gibson wrote: > On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: >> On 27.03.19 17:45, Igor Mammedov wrote: >>> On Wed, 27 Mar 2019 14:59:44 +0100 >>> David Hildenbrand wrote: >>> Right now we configure the pagesize quite early, when initializing

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread David Gibson
On Wed, Mar 27, 2019 at 09:06:53PM +0100, David Hildenbrand wrote: > On 27.03.19 17:45, Igor Mammedov wrote: > > On Wed, 27 Mar 2019 14:59:44 +0100 > > David Hildenbrand wrote: > > > >> Right now we configure the pagesize quite early, when initializing KVM. > >> This is long before system memory

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread David Hildenbrand
On 27.03.19 17:45, Igor Mammedov wrote: > On Wed, 27 Mar 2019 14:59:44 +0100 > David Hildenbrand wrote: > >> Right now we configure the pagesize quite early, when initializing KVM. >> This is long before system memory is actually allocated via >> memory_region_allocate_system_memory(), and

Re: [Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2019 14:59:44 +0100 David Hildenbrand wrote: > Right now we configure the pagesize quite early, when initializing KVM. > This is long before system memory is actually allocated via > memory_region_allocate_system_memory(), and therefore memory backends > marked as mapped. > >

[Qemu-devel] [PATCH v1] s390x/kvm: Configure page size after memory has actually been initialized

2019-03-27 Thread David Hildenbrand
Right now we configure the pagesize quite early, when initializing KVM. This is long before system memory is actually allocated via memory_region_allocate_system_memory(), and therefore memory backends marked as mapped. Instead, let's configure the maximum page size after initializing memory in