Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2018-01-08 Thread Richard Henderson
On 01/08/2018 04:58 AM, Alex Bennée wrote: > > Alex Bennée writes: > >> Richard Henderson writes: >> >>> On 12/11/2017 04:56 AM, Alex Bennée wrote: +static inline float16 float16_set_sign(float16 a, int sign) +{ +return

Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2018-01-08 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> On 12/11/2017 04:56 AM, Alex Bennée wrote: >>> +static inline float16 float16_set_sign(float16 a, int sign) >>> +{ >>> +return make_float16((float16_val(a) & 0x7fff) | (sign << 15));

Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2018-01-05 Thread Philippe Mathieu-Daudé
On 12/18/2017 06:44 PM, Richard Henderson wrote: > On 12/11/2017 04:56 AM, Alex Bennée wrote: >> +static inline float16 float16_set_sign(float16 a, int sign) >> +{ >> +return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); >> +} >> + > > 1) Do we use this anywhere? > > 2) While this

Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2017-12-18 Thread Alex Bennée
Richard Henderson writes: > On 12/11/2017 04:56 AM, Alex Bennée wrote: >> +static inline float16 float16_set_sign(float16 a, int sign) >> +{ >> +return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); >> +} >> + > > 1) Do we use this anywhere? Yes in

Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2017-12-18 Thread Richard Henderson
On 12/11/2017 04:56 AM, Alex Bennée wrote: > +static inline float16 float16_set_sign(float16 a, int sign) > +{ > +return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); > +} > + 1) Do we use this anywhere? 2) While this is probably in line with the other implementations, but going to

[Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper

2017-12-11 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index 32036382c6..17dfe60dbd 100644 --- a/include/fpu/softfloat.h +++ b/include/fpu/softfloat.h @@ -390,6