Re: [Qemu-devel] [PATCH v1 15/27] s390x/kvm: drop two debug prints

2017-09-25 Thread Richard Henderson 
On 09/18/2017 09:00 AM, David Hildenbrand wrote:
> Preparation for moving it out of kvm.c.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  target/s390x/kvm.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Richard Henderson 


r~

Re: [Qemu-devel] [PATCH v1 15/27] s390x/kvm: drop two debug prints

2017-09-25 Thread Thomas Huth 
On 18.09.2017 18:00, David Hildenbrand wrote:
> Preparation for moving it out of kvm.c.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  target/s390x/kvm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index 01c4125d21..d759edf1c8 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -1640,7 +1640,6 @@ int kvm_s390_cpu_restart(S390CPU *cpu)
>  SigpInfo si = {};
>  
>  run_on_cpu(CPU(cpu), sigp_restart, RUN_ON_CPU_HOST_PTR());
> -DPRINTF("DONE: KVM cpu restart: %p\n", >env);
>  return 0;
>  }
>  
> @@ -1742,7 +1741,6 @@ static int handle_sigp_single_dst(S390CPU *dst_cpu, 
> uint8_t order,
>  run_on_cpu(CPU(dst_cpu), sigp_cpu_reset, RUN_ON_CPU_HOST_PTR());
>  break;
>  default:
> -DPRINTF("KVM: unknown SIGP: 0x%x\n", order);
>  set_sigp_status(, SIGP_STAT_INVALID_ORDER);
>  }

Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v1 15/27] s390x/kvm: drop two debug prints

2017-09-18 Thread David Hildenbrand 
Preparation for moving it out of kvm.c.

Signed-off-by: David Hildenbrand 
---
 target/s390x/kvm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index 01c4125d21..d759edf1c8 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -1640,7 +1640,6 @@ int kvm_s390_cpu_restart(S390CPU *cpu)
 SigpInfo si = {};
 
 run_on_cpu(CPU(cpu), sigp_restart, RUN_ON_CPU_HOST_PTR());
-DPRINTF("DONE: KVM cpu restart: %p\n", >env);
 return 0;
 }
 
@@ -1742,7 +1741,6 @@ static int handle_sigp_single_dst(S390CPU *dst_cpu, 
uint8_t order,
 run_on_cpu(CPU(dst_cpu), sigp_cpu_reset, RUN_ON_CPU_HOST_PTR());
 break;
 default:
-DPRINTF("KVM: unknown SIGP: 0x%x\n", order);
 set_sigp_status(, SIGP_STAT_INVALID_ORDER);
 }
 
-- 
2.13.5