Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor

2018-11-15 Thread David Hildenbrand
On 15.11.18 17:48, Markus Armbruster wrote: > David Hildenbrand writes: > >> Let's use the new function. "NaN" and "inf" are now properly rejected. >> >> Signed-off-by: David Hildenbrand > > Whether this is a bug fix or just a change is debatable. But the commit > message's title should

Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor

2018-11-15 Thread Markus Armbruster
David Hildenbrand writes: > Let's use the new function. "NaN" and "inf" are now properly rejected. > > Signed-off-by: David Hildenbrand Whether this is a bug fix or just a change is debatable. But the commit message's title should highlight the change. Perhaps you want to steal from the one

Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor

2018-11-15 Thread Eric Blake
On 11/15/18 8:04 AM, David Hildenbrand wrote: Let's use the new function. "NaN" and "inf" are now properly rejected. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake Should there be any

Re: [Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor

2018-11-15 Thread David Hildenbrand
On 15.11.18 15:37, Eric Blake wrote: > On 11/15/18 8:04 AM, David Hildenbrand wrote: >> Let's use the new function. "NaN" and "inf" are now properly rejected. >> >> Signed-off-by: David Hildenbrand >> --- >> qapi/string-input-visitor.c | 6 ++ >> 1 file changed, 2 insertions(+), 4

[Qemu-devel] [PATCH v1 3/9] qapi: use qemu_strtod_finite() in string-input-visitor

2018-11-15 Thread David Hildenbrand
Let's use the new function. "NaN" and "inf" are now properly rejected. Signed-off-by: David Hildenbrand --- qapi/string-input-visitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index