Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-02 Thread Markus Armbruster
Eric Blake writes: > On 02/01/2016 06:07 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> No backend was setting an error when ending an implicit struct, >>> or when iterating a list. >> >> Perhaps "when ending the visit of a list or implicit

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Eric Blake
On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. > > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node"

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > No backend was setting an error when ending an implicit struct, > or when iterating a list. Perhaps "when ending the visit of a list or implicit struct, or when moving to the next list node" would be more precise. If you like it, I can do that on commit.

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Eric Blake
On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. > > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node"

[Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-01-29 Thread Eric Blake
No backend was setting an error when ending an implicit struct, or when iterating a list. Make the callers a bit easier to follow by making this a part of the contract, and removing the errp argument - callers can then unconditionally end an object as part of cleanup without having to think about