Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Changes since v11: >> * Use dup_const more. >> * Cleanup some gvec 2i and 2s routines. >> * Use more helpers and less gotos in target/arm/translate-a64.c. > > I just noticed the

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Changes since v11: > * Use dup_const more. > * Cleanup some gvec 2i and 2s routines. > * Use more helpers and less gotos in target/arm/translate-a64.c. I just noticed the aarch64 cross build breaks: n file included from

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 02/06/2018 08:24 AM, Alex Bennée wrote: >> >> I think this series is good to go. > > The x86 patch still require a volunteer to review ;) It looks good enough for me although I'm only a casual observer of x86 ;-) Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Philippe Mathieu-Daudé
On 02/06/2018 08:24 AM, Alex Bennée wrote: > > I think this series is good to go. The x86 patch still require a volunteer to review ;) signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Changes since v11: > * Use dup_const more. > * Cleanup some gvec 2i and 2s routines. > * Use more helpers and less gotos in target/arm/translate-a64.c. I think this series is good to go. A quick word on performance. I saw a

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-01-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180126045742.5487-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

[Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-01-25 Thread Richard Henderson
Changes since v11: * Use dup_const more. * Cleanup some gvec 2i and 2s routines. * Use more helpers and less gotos in target/arm/translate-a64.c. Changes since v10: * Squashed a fixup patch which escaped my attention while preparing the patch set. Ho hum. Changes since v9: *