Re: [Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

2017-05-03 Thread Max Reitz
On 29.04.2017 21:14, Eric Blake wrote: > Several copy-and-pasted alignment checks exist in qemu-io, which > could use some minor improvements: > > - Manual comparison against 0x1ff is not as clean as using our > alignment macros (QEMU_IS_ALIGNED) from osdep.h. > > - The error messages aren't

Re: [Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

2017-04-29 Thread Philippe Mathieu-Daudé
On 04/29/2017 04:14 PM, Eric Blake wrote: Several copy-and-pasted alignment checks exist in qemu-io, which could use some minor improvements: - Manual comparison against 0x1ff is not as clean as using our alignment macros (QEMU_IS_ALIGNED) from osdep.h. - The error messages aren't quite

[Qemu-devel] [PATCH v11 1/9] qemu-io: Improve alignment checks

2017-04-29 Thread Eric Blake
Several copy-and-pasted alignment checks exist in qemu-io, which could use some minor improvements: - Manual comparison against 0x1ff is not as clean as using our alignment macros (QEMU_IS_ALIGNED) from osdep.h. - The error messages aren't quite grammatically correct. Suggested-by: Philippe