Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-15 Thread Daniel P. Berrange
On Wed, Sep 14, 2016 at 04:59:50PM +0200, Kevin Wolf wrote: > Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > > Currently the QmpInputVisitor assumes that all scalar > > values are directly represented as their final types. > > ie it assumes an 'int' is using QInt, and a 'bool' is > >

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-14 Thread Kevin Wolf
Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 03:32:33PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > When using QemuOpts w/ qdict_crumple + QmpInputVisitor, you would > > do list of scalars in different manner 'foo.1=3,foo.2=5,foo.3=533' > > since this syntax is extendable

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-13 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Tue, Sep 13, 2016 at 11:05:08AM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > Currently the QmpInputVisitor assumes that all scalar >> > values are directly represented as their final types.

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-13 Thread Daniel P. Berrange
On Mon, Sep 12, 2016 at 01:39:50PM -0500, Eric Blake wrote: > On 09/05/2016 10:16 AM, Daniel P. Berrange wrote: > > Currently the QmpInputVisitor assumes that all scalar > > values are directly represented as their final types. > > ie it assumes an 'int' is using QInt, and a 'bool' is > > using

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 11:05:08AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > Currently the QmpInputVisitor assumes that all scalar > > values are directly represented as their final types. > > ie it assumes an 'int' is using QInt, and a 'bool' is >

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-13 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for QmpInputVisitor >

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-12 Thread Eric Blake
On 09/05/2016 10:16 AM, Daniel P. Berrange wrote: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for QmpInputVisitor >

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-12 Thread Daniel P. Berrange
On Mon, Sep 12, 2016 at 05:23:47PM +0100, Daniel P. Berrange wrote: > On Mon, Sep 12, 2016 at 06:21:32PM +0200, Markus Armbruster wrote: > > "Daniel P. Berrange" writes: > > > > > Currently the QmpInputVisitor assumes that all scalar > > > values are directly represented as

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-12 Thread Daniel P. Berrange
On Mon, Sep 12, 2016 at 06:21:32PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > Currently the QmpInputVisitor assumes that all scalar > > values are directly represented as their final types. > > ie it assumes an 'int' is using QInt, and a 'bool' is >

Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-12 Thread Markus Armbruster
"Daniel P. Berrange" writes: > Currently the QmpInputVisitor assumes that all scalar > values are directly represented as their final types. > ie it assumes an 'int' is using QInt, and a 'bool' is > using QBool. > > This adds an alternative constructor for QmpInputVisitor >

[Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion

2016-09-05 Thread Daniel P. Berrange
Currently the QmpInputVisitor assumes that all scalar values are directly represented as their final types. ie it assumes an 'int' is using QInt, and a 'bool' is using QBool. This adds an alternative constructor for QmpInputVisitor that will set it up such that it expects a QString for all scalar