Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-12 Thread Max Reitz
On 11.04.2016 07:18, Changlong Xie wrote: > On 03/30/2016 11:07 PM, Max Reitz wrote: >> On 30.03.2016 13:39, Alberto Garcia wrote: >>> On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: > It sounds like the argument here, and in Max's thread on > query-block-node-tree, is that we DO

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-10 Thread Changlong Xie
On 03/30/2016 11:07 PM, Max Reitz wrote: On 30.03.2016 13:39, Alberto Garcia wrote: On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: It sounds like the argument here, and in Max's thread on query-block-node-tree, is that we DO have cases where order matters, and so we need a way for the

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-06 Thread Wen Congyang
On 04/01/2016 11:20 PM, Max Reitz wrote: > On 31.03.2016 13:42, Alberto Garcia wrote: >> On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: I also have another (not directly related) question: why not simply use the node name when removing children? I understood that the idea was

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-04-01 Thread Max Reitz
On 31.03.2016 13:42, Alberto Garcia wrote: > On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: >>> I also have another (not directly related) question: why not simply >>> use the node name when removing children? I understood that the idea >>> was that it's possible to have the same node

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-31 Thread Dr. David Alan Gilbert
* Alberto Garcia (be...@igalia.com) wrote: > On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: > >> I also have another (not directly related) question: why not simply > >> use the node name when removing children? I understood that the idea > >> was that it's possible to have the same node

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-31 Thread Alberto Garcia
On Wed 30 Mar 2016 05:07:15 PM CEST, Max Reitz wrote: >> I also have another (not directly related) question: why not simply >> use the node name when removing children? I understood that the idea >> was that it's possible to have the same node attached twice to the >> same Quorum, but can you

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-30 Thread Max Reitz
On 30.03.2016 13:39, Alberto Garcia wrote: > On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: >>> It sounds like the argument here, and in Max's thread on >>> query-block-node-tree, is that we DO have cases where order matters, and >>> so we need a way for the hot-add operation to explicitly

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-30 Thread Alberto Garcia
On Tue 29 Mar 2016 05:51:22 PM CEST, Max Reitz wrote: >> It sounds like the argument here, and in Max's thread on >> query-block-node-tree, is that we DO have cases where order matters, and >> so we need a way for the hot-add operation to explicitly specify where >> in the list a child is inserted

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 18:03, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote: > >>> * Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: >

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Max Reitz
On 29.03.2016 18:03, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 29.03.2016 17:54, Dr. David Alan Gilbert wrote: >>> * Max Reitz (mre...@redhat.com) wrote: On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >>

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 17:54, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > >> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: > >>> * Eric Blake (ebl...@redhat.com) wrote: > On 03/29/2016 09:38 AM, Max Reitz wrote: > > On

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Max Reitz
On 29.03.2016 17:54, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: >> On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: >>> * Eric Blake (ebl...@redhat.com) wrote: On 03/29/2016 09:38 AM, Max Reitz wrote: > On 17.03.2016 10:56, Wen Congyang wrote: >> On

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 03/29/2016 09:38 AM, Max Reitz wrote: > >>> On 17.03.2016 10:56, Wen Congyang wrote: > On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > >>> >

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Max Reitz
On 29.03.2016 17:50, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 03/29/2016 09:38 AM, Max Reitz wrote: >>> On 17.03.2016 10:56, Wen Congyang wrote: On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: >>> >>> [...] >>> > The children.0 notation is really

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Max Reitz
On 29.03.2016 17:44, Eric Blake wrote: > On 03/29/2016 09:38 AM, Max Reitz wrote: >> On 17.03.2016 10:56, Wen Congyang wrote: >>> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: >> >> [...] >> The children.0 notation is really confusing in the way that Berto describes; I hit this a

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 03/29/2016 09:38 AM, Max Reitz wrote: > > On 17.03.2016 10:56, Wen Congyang wrote: > >> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > > > > [...] > > > >>> The children.0 notation is really confusing in the way that Berto > >>> describes; I

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Eric Blake
On 03/29/2016 09:38 AM, Max Reitz wrote: > On 17.03.2016 10:56, Wen Congyang wrote: >> On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > > [...] > >>> The children.0 notation is really confusing in the way that Berto >>> describes; I hit this a couple of months ago and it really doesn't

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-29 Thread Max Reitz
On 17.03.2016 10:56, Wen Congyang wrote: > On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: [...] >> The children.0 notation is really confusing in the way that Berto >> describes; I hit this a couple of months ago and it really doesn't >> make sense. > > Do you mean: read from children.1

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 03/17/2016 05:10 PM, Alberto Garcia wrote: >>> On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang >>> wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState {

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/16/2016 08:38 PM, Alberto Garcia wrote: > On Mon 14 Mar 2016 07:02:08 AM CET, Changlong Xie > wrote: > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/17/2016 05:10 PM, Alberto Garcia wrote: > On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang wrote: >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { >> bool rewrite_corrupted;/* true if the driver must rewrite-on-read >> corrupted >>

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 05:48 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 03/17/2016 05:10 PM, Alberto Garcia wrote: > >>> On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang > >>> wrote: >

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Alberto Garcia
On Mon 14 Mar 2016 07:02:08 AM CET, Changlong Xie wrote: >>> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { >>> bool rewrite_corrupted;/* true if the driver must rewrite-on-read >>> corrupted >>> * block if Quorum is reached.

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Wen Congyang
On 03/17/2016 07:25 PM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 03/17/2016 06:07 PM, Alberto Garcia wrote: >>> On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: > We should have the failure modes documented, and how you'll use it > after

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 06:07 PM, Alberto Garcia wrote: > > On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: > >>> We should have the failure modes documented, and how you'll use it > >>> after failover etc Without that it's really difficult to tell if

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Alberto Garcia
On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang wrote: > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > bool rewrite_corrupted;/* true if the driver must rewrite-on-read > corrupted > * block if Quorum is reached.

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 07:25 PM, Dr. David Alan Gilbert wrote: > > * Wen Congyang (we...@cn.fujitsu.com) wrote: > >> On 03/17/2016 06:07 PM, Alberto Garcia wrote: > >>> On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: > > We should have the failure

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-19 Thread Alberto Garcia
On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >> We should have the failure modes documented, and how you'll use it >> after failover etc Without that it's really difficult to tell if this >> naming is right. > > For COLO, children.0 is the real disk, children.1 is replication > driver.

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-18 Thread Wen Congyang
On 03/17/2016 06:07 PM, Alberto Garcia wrote: > On Thu 17 Mar 2016 10:56:09 AM CET, Wen Congyang wrote: >>> We should have the failure modes documented, and how you'll use it >>> after failover etc Without that it's really difficult to tell if this >>> naming is right. >> >> For COLO, children.0

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-18 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 03/17/2016 05:10 PM, Alberto Garcia wrote: > > On Thu 17 Mar 2016 02:22:40 AM CET, Wen Congyang > > wrote: > >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > >> bool rewrite_corrupted;/* true if the

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-15 Thread Wen Congyang
On 03/11/2016 08:21 PM, Alberto Garcia wrote: > On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { >> bool rewrite_corrupted;/* true if the driver must rewrite-on-read >> corrupted >> * block if Quorum

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-14 Thread Changlong Xie
On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-13 Thread Changlong Xie
On 03/11/2016 08:21 PM, Alberto Garcia wrote: On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { bool rewrite_corrupted;/* true if the driver must rewrite-on-read corrupted * block if Quorum is

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-11 Thread Alberto Garcia
On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: > @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { > bool rewrite_corrupted;/* true if the driver must rewrite-on-read > corrupted > * block if Quorum is reached. > */ > +

[Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-09 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Max Reitz