Re: [Qemu-devel] [PATCH v2] Add ability for user to specify mouse ungrab key

2017-12-14 Thread Daniel P. Berrange
On Thu, Dec 14, 2017 at 09:37:13AM -0500, John Arbuckle wrote: > Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. > This combination may not be very fun for the user to have to enter, so we > now enable the user to specify their own key as the ungrab key. Since the >

Re: [Qemu-devel] [PATCH v2] Add ability for user to specify mouse ungrab key

2017-12-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20171214143713.3795-1-programmingk...@gmail.com Subject: [Qemu-devel] [PATCH v2] Add ability for user to specify mouse ungrab key Type: series === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v2] Add ability for user to specify mouse ungrab key

2017-12-14 Thread John Arbuckle
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. This combination may not be very fun for the user to have to enter, so we now enable the user to specify their own key as the ungrab key. Since the function keys are the keys that don't tend to be used that often and are