Peter Maydell writes:
> On 13 June 2018 at 17:55, John Snow wrote:
[...]
>> It would only begin to matter terribly much if we actually decided we
>> wanted to do a doxygen-style doc generation for our internal APIs for
>> compatibility with, say, fancier IDEs than vim/emacs.
>
> We ought to do
On 15 June 2018 at 05:43, Thomas Huth wrote:
> On 14.06.2018 22:11, John Snow wrote:
>> Do you have a proposed standard / do we have some consensus on which
>> generator tool or doc format we'd most like to see in QEMU? I could put
>> in some elbow grease to shine up the block layer if so...
>
>
On 14.06.2018 22:11, John Snow wrote:
>
> On 06/14/2018 06:46 AM, Peter Maydell wrote:
[...]
>
> *cough* I hate the way it looks too, but C99 comments have a few things
> going for them:
>
> // A multi-line comment block like this has no extra lines and every
> // line in the comment is
On 06/14/2018 05:11 PM, John Snow wrote:
> On 06/14/2018 06:46 AM, Peter Maydell wrote:
>> On 13 June 2018 at 17:55, John Snow wrote:
>>> The same reasoning could be used to justify
>>>
>>> /* two
>>> * lines */
>>>
>>> as it's ... actually just two lines. I think people don't seem to like
>>>
On 06/14/2018 06:46 AM, Peter Maydell wrote:
> On 13 June 2018 at 17:55, John Snow wrote:
>> The same reasoning could be used to justify
>>
>> /* two
>> * lines */
>>
>> as it's ... actually just two lines. I think people don't seem to like
>> this much either (why? does it look 'naked' on
On 13 June 2018 at 17:55, John Snow wrote:
> The same reasoning could be used to justify
>
> /* two
> * lines */
>
> as it's ... actually just two lines. I think people don't seem to like
> this much either (why? does it look 'naked' on the end?)
I dislike the way it breaks up the line of
On 06/13/2018 08:30 AM, Peter Maydell wrote:
> On 12 June 2018 at 18:30, Richard Henderson
> wrote:
>> On 06/11/2018 04:17 AM, Peter Maydell wrote:
>>> The codebase has a bit of a mix of different multiline
>>> comment styles. State a preference for the Linux kernel
>>> style:
>>> /*
>>>
On Mon, Jun 11, 2018 at 03:17:16PM +0100, Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> *
On 12 June 2018 at 18:30, Richard Henderson
wrote:
> On 06/11/2018 04:17 AM, Peter Maydell wrote:
>> The codebase has a bit of a mix of different multiline
>> comment styles. State a preference for the Linux kernel
>> style:
>> /*
>> * Star on the left for each line.
>> * Leading
On Tue, 12 Jun 2018 12:47:29 -0600
Alex Williamson wrote:
> On Tue, 12 Jun 2018 20:12:02 +0200
> Thomas Huth wrote:
>
> > On 12.06.2018 19:30, Richard Henderson wrote:
> > > On 06/11/2018 04:17 AM, Peter Maydell wrote:
> > >> The codebase has a bit of a mix of different multiline
> > >>
On Tue, 12 Jun 2018 20:12:02 +0200
Thomas Huth wrote:
> On 12.06.2018 19:30, Richard Henderson wrote:
> > On 06/11/2018 04:17 AM, Peter Maydell wrote:
> >> The codebase has a bit of a mix of different multiline
> >> comment styles. State a preference for the Linux kernel
> >> style:
> >>
On 12.06.2018 19:30, Richard Henderson wrote:
> On 06/11/2018 04:17 AM, Peter Maydell wrote:
>> The codebase has a bit of a mix of different multiline
>> comment styles. State a preference for the Linux kernel
>> style:
>> /*
>> * Star on the left for each line.
>> * Leading
On 06/12/2018 02:30 PM, Richard Henderson wrote:
> On 06/11/2018 04:17 AM, Peter Maydell wrote:
>> The codebase has a bit of a mix of different multiline
>> comment styles. State a preference for the Linux kernel
>> style:
>> /*
>> * Star on the left for each line.
>> * Leading
On 06/11/2018 04:17 AM, Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a line
On Mon, 11 Jun 2018 17:40:35 +0100
Peter Maydell wrote:
> On 11 June 2018 at 17:15, Alex Williamson wrote:
> > Much preferred, thanks (tabs next? ;)
>
> CODING_STYLE already mandates spaces-only, no-tabs...
That was a joke, note the smiley. I know, I just don't like it.
Thanks,
Alex
On 11 June 2018 at 17:15, Alex Williamson wrote:
> Much preferred, thanks (tabs next? ;)
CODING_STYLE already mandates spaces-only, no-tabs...
thanks
-- PMM
On 06/11/2018 10:17 AM, Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a
On 11.06.2018 16:17, Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a line of
On Mon, 11 Jun 2018 15:17:16 +0100
Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each
Peter Maydell writes:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each go on a line of their own.
>
On Mon, 11 Jun 2018 15:17:16 +0100
Peter Maydell wrote:
> The codebase has a bit of a mix of different multiline
> comment styles. State a preference for the Linux kernel
> style:
> /*
> * Star on the left for each line.
> * Leading slash-star and trailing star-slash
> * each
On 06/11/2018 09:17 AM, Peter Maydell wrote:
The codebase has a bit of a mix of different multiline
comment styles. State a preference for the Linux kernel
style:
/*
* Star on the left for each line.
* Leading slash-star and trailing star-slash
* each go on a line of their
The codebase has a bit of a mix of different multiline
comment styles. State a preference for the Linux kernel
style:
/*
* Star on the left for each line.
* Leading slash-star and trailing star-slash
* each go on a line of their own.
*/
Signed-off-by: Peter Maydell
---
23 matches
Mail list logo
