Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
> On 9/27/2016 2:52 PM, Paolo Bonzini wrote: > > On 27/09/2016 13:37, Roy Shterman wrote: > > > > > +iscsi_url = iscsi_parse_full_url(iscsi, > > > > > uri_string_unescape(filename, -1, NULL)); > > > > >if (iscsi_url == NULL) { > > > > > -error_setg(errp, "Failed to parse URL :

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
On 27/09/2016 13:37, Roy Shterman wrote: >>> >>> +iscsi_url = iscsi_parse_full_url(iscsi, >>> uri_string_unescape(filename, -1, NULL)); >>> if (iscsi_url == NULL) { >>> -error_setg(errp, "Failed to parse URL : %s", filename); >>> +error_setg(errp, "Failed to parse URL :

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Roy Shterman
On 9/27/2016 2:52 PM, Paolo Bonzini wrote: On 27/09/2016 13:37, Roy Shterman wrote: +iscsi_url = iscsi_parse_full_url(iscsi, uri_string_unescape(filename, -1, NULL)); if (iscsi_url == NULL) { -error_setg(errp, "Failed to parse URL : %s", filename); +

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 13:37 schrieb Roy Shterman: On 9/27/2016 1:28 PM, Stefan Hajnoczi wrote: On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Roy Shterman
On 9/27/2016 1:28 PM, Stefan Hajnoczi wrote: On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: > iSER is a new transport layer supported in Libiscsi, > iSER provides a zero-copy RDMA capable interface that can > improve performance. > > New API is introduced in abstracion of the Libiscsi transport layer. > In order to use the

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-21 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474481984-10452-1-git-send-email-ro...@mellanox.com Subject: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-21 Thread Roy Shterman
iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi transport layer. In order to use the new iSER transport, one need to add the ?iser option at the end of Libiscsi