Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-19 Thread Peter Maydell
On 18 January 2017 at 17:26, Laszlo Ersek wrote: > In brief, for one data point, I'd be fine if we didn't tie this change > to machine types. We seem to have arrived at a consensus that we don't need to version-constrain this change, so I'm applying Ard's patch to

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Laszlo Ersek
On 01/18/17 18:02, Ard Biesheuvel wrote: > On 18 January 2017 at 15:55, Laszlo Ersek wrote: >> On 01/18/17 16:18, Igor Mammedov wrote: >>> On Tue, 17 Jan 2017 10:56:53 + >>> Peter Maydell wrote: >>> On 17 January 2017 at 09:49, Andrew Jones

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Ard Biesheuvel
On 18 January 2017 at 15:55, Laszlo Ersek wrote: > On 01/18/17 16:18, Igor Mammedov wrote: >> On Tue, 17 Jan 2017 10:56:53 + >> Peter Maydell wrote: >> >>> On 17 January 2017 at 09:49, Andrew Jones wrote: In some cases

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Laszlo Ersek
On 01/18/17 16:18, Igor Mammedov wrote: > On Tue, 17 Jan 2017 10:56:53 + > Peter Maydell wrote: > >> On 17 January 2017 at 09:49, Andrew Jones wrote: >>> In some cases the problem we're solving with the compat guards is >>> a bit hypothetical,

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Igor Mammedov
On Tue, 17 Jan 2017 10:56:53 + Peter Maydell wrote: > On 17 January 2017 at 09:49, Andrew Jones wrote: > > In some cases the problem we're solving with the compat guards is > > a bit hypothetical, but, IMHO, nonetheless a good practice. While >

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-18 Thread Ard Biesheuvel
On 17 January 2017 at 09:49, Andrew Jones wrote: > On Mon, Jan 16, 2017 at 07:31:33PM +, Ard Biesheuvel wrote: >> On 16 January 2017 at 18:20, Peter Maydell wrote: >> > On 16 January 2017 at 17:30, Ard Biesheuvel >> >

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Michael S. Tsirkin
On Mon, Jan 16, 2017 at 11:35:04PM +0100, Laszlo Ersek wrote: > On 01/16/17 22:23, Ard Biesheuvel wrote: > > On 16 January 2017 at 21:13, Laszlo Ersek wrote: > >> On 01/16/17 20:31, Ard Biesheuvel wrote: > >>> On 16 January 2017 at 18:20, Peter Maydell

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Peter Maydell
On 17 January 2017 at 09:49, Andrew Jones wrote: > In some cases the problem we're solving with the compat guards is > a bit hypothetical, but, IMHO, nonetheless a good practice. While > we may be sure that AAVMF and Linux will be fine with this table > changing under their

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Laszlo Ersek
On 01/17/17 10:06, Ard Biesheuvel wrote: > On 17 January 2017 at 08:50, Laszlo Ersek wrote: >> (my reply is no longer related to the patch, so maybe I shouldn't send >> it... I can't resist, sorry :)) >> >> On 01/17/17 08:47, Ard Biesheuvel wrote: >>> On 16 January 2017 at

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Andrew Jones
On Mon, Jan 16, 2017 at 07:31:33PM +, Ard Biesheuvel wrote: > On 16 January 2017 at 18:20, Peter Maydell wrote: > > On 16 January 2017 at 17:30, Ard Biesheuvel > > wrote: > >> On 16 January 2017 at 17:25, Peter Maydell

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Ard Biesheuvel
On 17 January 2017 at 08:50, Laszlo Ersek wrote: > (my reply is no longer related to the patch, so maybe I shouldn't send > it... I can't resist, sorry :)) > > On 01/17/17 08:47, Ard Biesheuvel wrote: >> On 16 January 2017 at 22:35, Laszlo Ersek wrote: > >>>

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-17 Thread Laszlo Ersek
(my reply is no longer related to the patch, so maybe I shouldn't send it... I can't resist, sorry :)) On 01/17/17 08:47, Ard Biesheuvel wrote: > On 16 January 2017 at 22:35, Laszlo Ersek wrote: >> The UEFI memory map will reflect allocations from the GCD memory space, >> for

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Ard Biesheuvel
On 16 January 2017 at 22:35, Laszlo Ersek wrote: > On 01/16/17 22:23, Ard Biesheuvel wrote: >> On 16 January 2017 at 21:13, Laszlo Ersek wrote: >>> On 01/16/17 20:31, Ard Biesheuvel wrote: On 16 January 2017 at 18:20, Peter Maydell

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Laszlo Ersek
On 01/16/17 22:23, Ard Biesheuvel wrote: > On 16 January 2017 at 21:13, Laszlo Ersek wrote: >> On 01/16/17 20:31, Ard Biesheuvel wrote: >>> On 16 January 2017 at 18:20, Peter Maydell wrote: On 16 January 2017 at 17:30, Ard Biesheuvel

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Ard Biesheuvel
On 16 January 2017 at 21:13, Laszlo Ersek wrote: > On 01/16/17 20:31, Ard Biesheuvel wrote: >> On 16 January 2017 at 18:20, Peter Maydell wrote: >>> On 16 January 2017 at 17:30, Ard Biesheuvel >>> wrote: On 16 January

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Laszlo Ersek
On 01/16/17 20:31, Ard Biesheuvel wrote: > On 16 January 2017 at 18:20, Peter Maydell wrote: >> On 16 January 2017 at 17:30, Ard Biesheuvel >> wrote: >>> On 16 January 2017 at 17:25, Peter Maydell wrote: On 13

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Ard Biesheuvel
On 16 January 2017 at 18:20, Peter Maydell wrote: > On 16 January 2017 at 17:30, Ard Biesheuvel wrote: >> On 16 January 2017 at 17:25, Peter Maydell wrote: >>> On 13 January 2017 at 17:32, Ard Biesheuvel

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Peter Maydell
On 16 January 2017 at 17:30, Ard Biesheuvel wrote: > On 16 January 2017 at 17:25, Peter Maydell wrote: >> On 13 January 2017 at 17:32, Ard Biesheuvel >> wrote: >>> Linux for arm64 v4.10 and later will complain if

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Ard Biesheuvel
On 16 January 2017 at 17:25, Peter Maydell wrote: > On 13 January 2017 at 17:32, Ard Biesheuvel wrote: >> Linux for arm64 v4.10 and later will complain if the ECAM config space is >> not reserved in the ACPI namespace: >> >> acpi PNP0A08:00:

Re: [Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-16 Thread Peter Maydell
On 13 January 2017 at 17:32, Ard Biesheuvel wrote: > Linux for arm64 v4.10 and later will complain if the ECAM config space is > not reserved in the ACPI namespace: > > acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x3f00-0x3fff] not > reserved in ACPI

[Qemu-devel] [PATCH v2] hw/arm/virt-acpi - reserve ECAM space as PNP0C02 device

2017-01-13 Thread Ard Biesheuvel
Linux for arm64 v4.10 and later will complain if the ECAM config space is not reserved in the ACPI namespace: acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x3f00-0x3fff] not reserved in ACPI namespace The rationale is that OSes that don't consume the MCFG table should still be able