Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: NACK I'm not going to merge this patch: If you terminate QEMU and launch it again the NIC gets a different MAC address. Some guest operating systems are sensitive to this - under For these users must use -device

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread mike
On 10/18/2013 05:00 PM, Stefan Hajnoczi wrote: On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: NACK I'm not going to merge this patch: If you terminate QEMU and launch it again the NIC gets a different MAC address. Some guest operating systems are sensitive to this - under For these

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-18 Thread Stefan Hajnoczi
On Fri, Oct 18, 2013 at 11:44 AM, mike qiud...@linux.vnet.ibm.com wrote: On 10/18/2013 05:00 PM, Stefan Hajnoczi wrote: On Fri, Oct 18, 2013 at 10:54:13AM +0800, mike wrote: NACK I'm not going to merge this patch: If you terminate QEMU and launch it again the NIC gets a different MAC

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 09:33:06PM +0800, mike wrote: On 10/15/2013 08:36 PM, Eric Blake wrote: On 10/14/2013 11:07 PM, Stefan Weil wrote: Is it reasonable to get a random mac address in your guest? I don't think so. It would no longer be possible to connect to a guest using ssh, restart that

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-17 Thread mike
On 10/17/2013 08:30 PM, Stefan Hajnoczi wrote: On Tue, Oct 15, 2013 at 09:33:06PM +0800, mike wrote: On 10/15/2013 08:36 PM, Eric Blake wrote: On 10/14/2013 11:07 PM, Stefan Weil wrote: Is it reasonable to get a random mac address in your guest? I don't think so. It would no longer be

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread Stefan Weil
Am 15.10.2013 07:57, schrieb mike: On 10/15/2013 01:07 PM, Stefan Weil wrote: Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index, this

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread mike
On 10/15/2013 02:05 PM, Stefan Weil wrote: Am 15.10.2013 07:57, schrieb mike: On 10/15/2013 01:07 PM, Stefan Weil wrote: Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread Eric Blake
On 10/14/2013 11:07 PM, Stefan Weil wrote: Is it reasonable to get a random mac address in your guest? I don't think so. It would no longer be possible to connect to a guest using ssh, restart that guest and connect again with ssh. Agreed - libvirt ALWAYS passes a MAC to qemu, even if the

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread mike
On 10/15/2013 08:36 PM, Eric Blake wrote: On 10/14/2013 11:07 PM, Stefan Weil wrote: Is it reasonable to get a random mac address in your guest? I don't think so. It would no longer be possible to connect to a guest using ssh, restart that guest and connect again with ssh. Agreed - libvirt

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by default, assume that each guest has one nic. In this situation, all the guest's nic has the same mac address. This patch is to solve this bug.

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread mike
On 10/14/2013 03:30 PM, Mike Qiu wrote: Sorry for the first version make a mistake of the sender. There is no difference with v1. Thanks Mike The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by default, assume that

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Stefan Weil
Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread mike
On 10/15/2013 01:07 PM, Stefan Weil wrote: Am 15.10.2013 06:17, schrieb Mike Qiu: Changelog to v1: Find remainder of macaddr-a[5] by modulo 256, otherwise it may be overflow by add index++. The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when