Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries

2016-05-06 Thread Michael Tokarev
22.03.2016 18:39, Markus Armbruster wrote: > Peter Xu writes: > >> Here we use one g_strdup_printf() to replace the two stack allocated >> array, considering it's more convenient, safe, and as long as it's >> called rarely only when quorum device opens. This will remove the >>

Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries

2016-03-22 Thread Markus Armbruster
Peter Xu writes: > Here we use one g_strdup_printf() to replace the two stack allocated > array, considering it's more convenient, safe, and as long as it's > called rarely only when quorum device opens. This will remove the > unbound stack warning when compiling with

[Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries

2016-03-21 Thread Peter Xu
Here we use one g_strdup_printf() to replace the two stack allocated array, considering it's more convenient, safe, and as long as it's called rarely only when quorum device opens. This will remove the unbound stack warning when compiling with "-Wstack-usage=100". Reviewed-by: Eric Blake