Re: [Qemu-devel] [PATCH v2 00/10] ccid and libcacard fixes for windows/mingw
On Mon, 2013-04-15 at 15:31 +0200, Marc-André Lureau wrote: Hi On Wed, Mar 27, 2013 at 9:36 PM, Alon Levy al...@redhat.com wrote: This series: 1. fixes windows guests to show the ccid device 2. changes libcacard to use glib 3. makes libcacard build under mingw 4. does some cleanups It contains a few patches already posted to the list (the two Jim Meyering patches) which were already acked. I'll make a pull request once this had some time to be reviewed. Tested with a fedora and windows 7 guest. The main non cleanup patches are: hw/usb/dev-smartcard-reader: support windows guest libcacard: correct T0 historical bytes size The patch series doesn't do what you describe. So you want me to update this cover letter that doesn't get committed, no problem, I will in a follow up message, but meanwhile could you take a look at the updated patches per your requests from v1? Many patches are missing from the v1: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg02925.html Many patches are missing on purpose, because they are either yours and so I acked them implicitly by sending the v1 patch series, or they are mine and have already been acked by me. -- Marc-André Lureau
Re: [Qemu-devel] [PATCH v2 00/10] ccid and libcacard fixes for windows/mingw
Hi On Wed, Mar 27, 2013 at 9:36 PM, Alon Levy al...@redhat.com wrote: This series: 1. fixes windows guests to show the ccid device 2. changes libcacard to use glib 3. makes libcacard build under mingw 4. does some cleanups It contains a few patches already posted to the list (the two Jim Meyering patches) which were already acked. I'll make a pull request once this had some time to be reviewed. Tested with a fedora and windows 7 guest. The main non cleanup patches are: hw/usb/dev-smartcard-reader: support windows guest libcacard: correct T0 historical bytes size The patch series doesn't do what you describe. Many patches are missing from the v1: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg02925.html -- Marc-André Lureau
[Qemu-devel] [PATCH v2 00/10] ccid and libcacard fixes for windows/mingw
This series: 1. fixes windows guests to show the ccid device 2. changes libcacard to use glib 3. makes libcacard build under mingw 4. does some cleanups It contains a few patches already posted to the list (the two Jim Meyering patches) which were already acked. I'll make a pull request once this had some time to be reviewed. Tested with a fedora and windows 7 guest. The main non cleanup patches are: hw/usb/dev-smartcard-reader: support windows guest libcacard: correct T0 historical bytes size v2: only resent patches that were not acked before. did all the changes per Marc Andre's comments. Please look at the g_debug one, I'm not sure about the ifdeffery there (not if it works, but if it looks ok). Alon Levy (10): libcacard: change default ATR ccid-card-passthru: add atr check ccid-card-passthru, dev-smartcard-reader: add debug environment variables dev-smartcard-reader: define structs for CCID_Parameter internals dev-smartcard-reader: change default protocol to T=0 dev-smartcard-reader: copy atr protocol to ccid parameters libcacard/vreader: add debugging messages for apdu libcacard: move atr setting from macro to function dev-smartcard-reader: empty implementation for Mechanical (fail correctly) libcacard/cac: change big switch functions to single return point Makefile.objs | 1 + hw/ccid-card-passthru.c | 61 hw/usb/dev-smartcard-reader.c | 130 -- include/qemu-common.h | 5 ++ libcacard/cac.c | 80 +- libcacard/cac.h | 8 +++ libcacard/vcard_emul_nss.c| 14 - libcacard/vcardt.c| 40 + libcacard/vcardt.h| 5 -- libcacard/vcardt_internal.h | 6 ++ libcacard/vreader.c | 77 + util/cutils.c | 23 12 files changed, 384 insertions(+), 66 deletions(-) create mode 100644 libcacard/vcardt.c create mode 100644 libcacard/vcardt_internal.h -- 1.8.1.4
