Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Markus Armbruster
Marc-André Lureau writes: > On Fri, May 5, 2017 at 4:35 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> >> One of the most important maintainer duties is saying "no". It's also >> >> one of the least

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Marc-André Lureau
On Fri, May 5, 2017 at 4:35 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > >> One of the most important maintainer duties is saying "no". It's also > >> one of the least fun duties. > >> > >> > > It doesn't sound like a "no" :) > >

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.05.2017 um 21:01 hat Markus Armbruster geschrieben: >> Now let me take a step back: we need to crack the "jobs" problem anyway. >> Merging this series now would in a way add another special case of the >> general case "jobs" before adding the general

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, May 4, 2017 at 11:02 PM Markus Armbruster wrote: > >> I figure everyone interested has had his say. Let me try to summarize >> and draw my conclusions. >> >> Commands + events can replace asynchronous

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Kevin Wolf
Am 04.05.2017 um 21:01 hat Markus Armbruster geschrieben: > Now let me take a step back: we need to crack the "jobs" problem anyway. > Merging this series now would in a way add another special case of the > general case "jobs" before adding the general case. In other words, > create more stuff

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-05 Thread Marc-André Lureau
Hi On Thu, May 4, 2017 at 11:02 PM Markus Armbruster wrote: > I figure everyone interested has had his say. Let me try to summarize > and draw my conclusions. > > Commands + events can replace asynchronous commands (they did). > > Asynchronous commands cannot replace events,

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-04 Thread Markus Armbruster
I figure everyone interested has had his say. Let me try to summarize and draw my conclusions. Commands + events can replace asynchronous commands (they did). Asynchronous commands cannot replace events, because "interesting" side effects of commands need to be broadcast. Doesn't mean

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-02 Thread Kevin Wolf
Am 02.05.2017 um 11:05 hat Marc-André Lureau geschrieben: > On Fri, Apr 28, 2017 at 11:13 PM Kevin Wolf wrote: > > > Am 28.04.2017 um 17:55 hat Marc-André Lureau geschrieben: > > > On Tue, Apr 25, 2017 at 2:23 PM Kevin Wolf wrote: > > > > > > > Am 24.04.2017

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-02 Thread Marc-André Lureau
Hi On Fri, Apr 28, 2017 at 11:13 PM Kevin Wolf wrote: > Am 28.04.2017 um 17:55 hat Marc-André Lureau geschrieben: > > On Tue, Apr 25, 2017 at 2:23 PM Kevin Wolf wrote: > > > > > Am 24.04.2017 um 21:10 hat Markus Armbruster geschrieben: > > > > With 2.9 out

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-05-02 Thread Gerd Hoffmann
Hi, > > As explained in the cover letter, an async command may cancel the > > ongoing operation on disconnect. > > But that's not what you generally want. You don't want to abort your > backup just because libvirt lost its monitor connection, but qemu should > continue to copy the data, and

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-28 Thread Kevin Wolf
Am 28.04.2017 um 17:55 hat Marc-André Lureau geschrieben: > On Tue, Apr 25, 2017 at 2:23 PM Kevin Wolf wrote: > > > Am 24.04.2017 um 21:10 hat Markus Armbruster geschrieben: > > > With 2.9 out of the way, how can we make progress on this one? > > > > > > I can see two ways to

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-28 Thread Marc-André Lureau
Hi On Tue, Apr 25, 2017 at 2:23 PM Kevin Wolf wrote: > Am 24.04.2017 um 21:10 hat Markus Armbruster geschrieben: > > With 2.9 out of the way, how can we make progress on this one? > > > > I can see two ways to get asynchronous QMP commands accepted: > > > > 1. We break QMP

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-25 Thread Kevin Wolf
Am 24.04.2017 um 21:10 hat Markus Armbruster geschrieben: > With 2.9 out of the way, how can we make progress on this one? > > I can see two ways to get asynchronous QMP commands accepted: > > 1. We break QMP compatibility in QEMU 3.0 and convert all long-running >tasks from "synchronous

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-25 Thread Daniel P. Berrange
On Mon, Apr 24, 2017 at 09:10:22PM +0200, Markus Armbruster wrote: > With 2.9 out of the way, how can we make progress on this one? > > I can see two ways to get asynchronous QMP commands accepted: > > 1. We break QMP compatibility in QEMU 3.0 and convert all long-running >tasks from

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-25 Thread Markus Armbruster
John Snow writes: > On 04/24/2017 03:10 PM, Markus Armbruster wrote: >> With 2.9 out of the way, how can we make progress on this one? >> > > Throw rocks at my window late at night. Refuse to stop until there is > consensus. > >> I can see two ways to get asynchronous QMP

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-24 Thread John Snow
On 04/24/2017 03:10 PM, Markus Armbruster wrote: > With 2.9 out of the way, how can we make progress on this one? > Throw rocks at my window late at night. Refuse to stop until there is consensus. > I can see two ways to get asynchronous QMP commands accepted: > > 1. We break QMP

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-24 Thread Markus Armbruster
With 2.9 out of the way, how can we make progress on this one? I can see two ways to get asynchronous QMP commands accepted: 1. We break QMP compatibility in QEMU 3.0 and convert all long-running tasks from "synchronous command + event" to "asynchronous command". This is design option 1

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-02-02 Thread Stefan Hajnoczi
On Wed, Feb 01, 2017 at 08:25:10PM +, Marc-André Lureau wrote: > Hi > > On Wed, Feb 1, 2017 at 8:26 PM Stefan Hajnoczi wrote: > > > On Mon, Jan 30, 2017 at 01:18:16PM -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Tue, Jan

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-02-01 Thread Marc-André Lureau
Hi On Wed, Feb 1, 2017 at 8:26 PM Stefan Hajnoczi wrote: > On Mon, Jan 30, 2017 at 01:18:16PM -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote: > > > > Hi > > > > > > > > -

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-02-01 Thread Stefan Hajnoczi
On Mon, Jan 30, 2017 at 01:18:16PM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-31 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > It would be nice for this series to evolve to a generic QMP jobs series >> > so that all background operations are visible to the client and a useful >> > subset of management primitives can be implemented on a per-command >> > basis. Both

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-30 Thread Gerd Hoffmann
Hi, > > It would be nice for this series to evolve to a generic QMP jobs series > > so that all background operations are visible to the client and a useful > > subset of management primitives can be implemented on a per-command > > basis. Both live migration and existing block jobs could use

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-30 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > > > > - Original Message - > > > > > On Wed, Jan 18, 2017 at

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-30 Thread Stefan Hajnoczi
On Tue, Jan 24, 2017 at 01:43:17PM -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > > > - Original Message - > > > > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > > > >

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-25 Thread Markus Armbruster
Cc'ing block job people. Marc-André Lureau writes: > Hi, > > One of initial design goals of QMP was to have "asynchronous command > completion" (http://wiki.qemu.org/Features/QAPI). Unfortunately, that > goal was not fully achieved, and some broken bits left were

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-24 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > > - Original Message - > > > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > > > Hi, > > > > > > CCing Jeff Cody and John Snow, who have been working on

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-24 Thread Stefan Hajnoczi
On Mon, Jan 23, 2017 at 06:27:29AM -0500, Marc-André Lureau wrote: > - Original Message - > > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > > Hi, > > > > CCing Jeff Cody and John Snow, who have been working on generalizing > > Block Job APIs to generic background

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-23 Thread Marc-André Lureau
Hi - Original Message - > On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > > Hi, > > CCing Jeff Cody and John Snow, who have been working on generalizing > Block Job APIs to generic background jobs. There is some overlap > between async commands and background jobs.

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-23 Thread Stefan Hajnoczi
On Wed, Jan 18, 2017 at 08:03:07PM +0400, Marc-André Lureau wrote: > Hi, CCing Jeff Cody and John Snow, who have been working on generalizing Block Job APIs to generic background jobs. There is some overlap between async commands and background jobs. > > One of initial design goals of QMP was

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-18 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170118160332.13390-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/25] qmp: add async command

[Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-01-18 Thread Marc-André Lureau
Hi, One of initial design goals of QMP was to have "asynchronous command completion" (http://wiki.qemu.org/Features/QAPI). Unfortunately, that goal was not fully achieved, and some broken bits left were removed progressively until commit 65207c59d that removed async command support. Note that