Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-11 Thread Emilio G. Cota
On Wed, Apr 11, 2018 at 09:27:57 +1000, Richard Henderson wrote: > On 04/11/2018 12:23 AM, Emilio G. Cota wrote: > > case DISAS_STOP: > > -gen_goto_tb(&ctx, 0, ctx.pc); > > +tcg_gen_lookup_and_goto_ptr(); > > You need to write ctx.pc back to the pc first, e.g. > >

Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-10 Thread Richard Henderson
On 04/11/2018 12:23 AM, Emilio G. Cota wrote: > case DISAS_STOP: > -gen_goto_tb(&ctx, 0, ctx.pc); > +tcg_gen_lookup_and_goto_ptr(); You need to write ctx.pc back to the pc first, e.g. gen_save_pc(ctx.pc); tcg_gen_lookup_and_goto_ptr(); r~

Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-10 Thread Emilio G. Cota
On Tue, Apr 10, 2018 at 13:56:25 +1000, Richard Henderson wrote: > Ok, well, there are existing bugs within the MIPS translation here, and we > might as well fix them within this patch set. > > (1) The description for BS_STOP says we want to stop, but (what will become) > mips_tr_tb_stop calls got

Re: [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-09 Thread Richard Henderson
On 04/07/2018 04:19 AM, Emilio G. Cota wrote: > Reviewed-by: Philippe Mathieu-Daudé > Cc: Aurelien Jarno > Cc: Yongbok Kim > Signed-off-by: Emilio G. Cota > --- > target/mips/translate.c | 186 > +++- > 1 file changed, 91 insertions(+), 95 deletions

[Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType

2018-04-06 Thread Emilio G. Cota
Reviewed-by: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Emilio G. Cota --- target/mips/translate.c | 186 +++- 1 file changed, 91 insertions(+), 95 deletions(-) diff --git a/target/mips/translate.c b/target/mips/transla