Re: [Qemu-devel] [PATCH v2 2/3] vhost-user: fix ioeventfd_enabled

[Michael S. Tsirkin]

On Sat, Dec 15, 2018 at 04:03:52AM -0800, Li Qiang wrote:
> Currently, the vhost-user-test assumes the eventfd is available.
> However it's not true because the accel is qtest. So the
> 'vhost_set_vring_file' will not add fds to the msg and the server
> side of vhost-user-test will be broken. The bug is in 'ioeventfd_enabled'.
> We should make this function return true if not using kvm accel.
> 
> Signed-off-by: Li Qiang 

Reviewed-by: Michael S. Tsirkin 

> ---
> v2: change the fix in 'ioeventfd_enabled' per Paolo's review
> 
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index e09bed0e4a..564a31d12c 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -207,7 +207,7 @@ struct vhost_user {
>  
>  static bool ioeventfd_enabled(void)
>  {
> -return kvm_enabled() && kvm_eventfds_enabled();
> +return !kvm_enabled() || kvm_eventfds_enabled();
>  }
>  
>  static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
> -- 
> 2.17.1
> 
> 

[Qemu-devel] [PATCH v2 2/3] vhost-user: fix ioeventfd_enabled

[Li Qiang]

Currently, the vhost-user-test assumes the eventfd is available.
However it's not true because the accel is qtest. So the
'vhost_set_vring_file' will not add fds to the msg and the server
side of vhost-user-test will be broken. The bug is in 'ioeventfd_enabled'.
We should make this function return true if not using kvm accel.

Signed-off-by: Li Qiang 
---
v2: change the fix in 'ioeventfd_enabled' per Paolo's review

 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index e09bed0e4a..564a31d12c 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -207,7 +207,7 @@ struct vhost_user {
 
 static bool ioeventfd_enabled(void)
 {
-return kvm_enabled() && kvm_eventfds_enabled();
+return !kvm_enabled() || kvm_eventfds_enabled();
 }
 
 static int vhost_user_read(struct vhost_dev *dev, VhostUserMsg *msg)
-- 
2.17.1