Re: [Qemu-devel] [PATCH v2 2/4] vmdk: Implement .bdrv_co_create callback

2018-06-13 Thread Markus Armbruster
Still only looking at QAPI-related aspects. Fam Zheng writes: > This makes VMDK support x-blockdev-create. The implementation reuses the > image creation code in vmdk_co_create_opts which now acceptes a callback > pointer to "retrieve" BlockBackend pointers from the caller. This way we > separat

[Qemu-devel] [PATCH v2 2/4] vmdk: Implement .bdrv_co_create callback

2018-05-15 Thread Fam Zheng
This makes VMDK support x-blockdev-create. The implementation reuses the image creation code in vmdk_co_create_opts which now acceptes a callback pointer to "retrieve" BlockBackend pointers from the caller. This way we separate the logic between file/extent acquisition and initialization. The QAPI