Re: [Qemu-devel] [PATCH v2 2/6] target-arm: Fix handling of SCR.SMD

2016-02-12 Thread Edgar E. Iglesias
On Thu, Feb 11, 2016 at 04:03:25PM +, Peter Maydell wrote: > We weren't quite implementing the handling of SCR.SMD correctly. > The condition governing whether the SMD bit should apply only > for NS state is "is EL3 is AArch32", not "is the current EL AArch32". > Fix the condition, and clarify

[Qemu-devel] [PATCH v2 2/6] target-arm: Fix handling of SCR.SMD

2016-02-11 Thread Peter Maydell
We weren't quite implementing the handling of SCR.SMD correctly. The condition governing whether the SMD bit should apply only for NS state is "is EL3 is AArch32", not "is the current EL AArch32". Fix the condition, and clarify the comment both to reflect this and to expand slightly on what's