Re: [Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-16 Thread David Hildenbrand
On 11.09.19 23:26, Richard Henderson wrote: > On 9/6/19 3:57 AM, David Hildenbrand wrote: >> +srca2 = access_prepare(env, dest, l, MMU_DATA_LOAD, ra); >> +desta = access_prepare(env, dest, l, MMU_DATA_STORE, ra); > > We should find a way to perform this in one step. > RWM isn't uncommon...

Re: [Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +srca2 = access_prepare(env, dest, l, MMU_DATA_LOAD, ra); > +desta = access_prepare(env, dest, l, MMU_DATA_STORE, ra); We should find a way to perform this in one step. RWM isn't uncommon... That said, Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v2 20/28] s390x/tcg: OC: Fault-safe handling

2019-09-06 Thread David Hildenbrand
We can process a maximum of 256 bytes, crossing two pages. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0366cbc753..ff57fec8de 10064