Re: [Qemu-devel] [PATCH v2 26/28] s390x/tcg: MVST: Fault-safe handling

2019-09-16 Thread David Hildenbrand
On 11.09.19 23:52, Richard Henderson wrote: > On 9/6/19 3:57 AM, David Hildenbrand wrote: >> +/* >> + * Our access should not exceed single pages, as we must not report >> access >> + * exceptions exceeding the actually copied range (which we don't know >> at >> + * this point).

Re: [Qemu-devel] [PATCH v2 26/28] s390x/tcg: MVST: Fault-safe handling

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > +/* > + * Our access should not exceed single pages, as we must not report > access > + * exceptions exceeding the actually copied range (which we don't know at > + * this point). We might over-indicate watchpoints within the pages > +

[Qemu-devel] [PATCH v2 26/28] s390x/tcg: MVST: Fault-safe handling

2019-09-06 Thread David Hildenbrand
Access at most single pages and document why. Using the access helpers might over-indicate watchpoints within the same page, I guess we can live with that. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 23 --- 1 file changed, 16 insertions(+), 7