Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
On 2017/2/16 21:04, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 4:49 PM Hailiang Zhang < zhang.zhanghaili...@huawei.com> wrote: Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Marc-André Lureau
Hi On Thu, Feb 16, 2017 at 4:49 PM Hailiang Zhang < zhang.zhanghaili...@huawei.com> wrote: > Hi, > > On 2017/2/16 18:40, Marc-André Lureau wrote: > > Hi > > > > On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < > > zhang.zhanghaili...@huawei.com> wrote: > > > >> We can call

Re: [Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-16 Thread Hailiang Zhang
Hi, On 2017/2/16 18:40, Marc-André Lureau wrote: Hi On Thu, Feb 16, 2017 at 10:08 AM zhanghailiang < zhang.zhanghaili...@huawei.com> wrote: We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context.

[Qemu-devel] [PATCH v2 3/4] char: remove the right fd been watched in qemu_chr_fe_set_handlers()

2017-02-15 Thread zhanghailiang
We can call qemu_chr_fe_set_handlers() to add/remove fd been watched in 'context' which can be either default main context or other explicit context. But the original logic is not correct, we didn't remove the right fd because we call g_main_context_find_source_by_id(NULL, tag) which always try to