Re: [Qemu-devel] [PATCH v2 3/6] block/dirty-bitmap: change semantics of enabled predicate

2019-02-18 Thread John Snow
On 2/18/19 11:39 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> Currently, enabled means something like "the status of the bitmap >> is ACTIVE." After this patch, it should mean exclusively: "This >> bitmap is recording guest writes, and is allowed to do so." >>

Re: [Qemu-devel] [PATCH v2 3/6] block/dirty-bitmap: change semantics of enabled predicate

2019-02-18 Thread Vladimir Sementsov-Ogievskiy
14.02.2019 2:23, John Snow wrote: > Currently, enabled means something like "the status of the bitmap > is ACTIVE." After this patch, it should mean exclusively: "This > bitmap is recording guest writes, and is allowed to do so." > > In many places, this is how this predicate was already used. >

[Qemu-devel] [PATCH v2 3/6] block/dirty-bitmap: change semantics of enabled predicate

2019-02-13 Thread John Snow
Currently, enabled means something like "the status of the bitmap is ACTIVE." After this patch, it should mean exclusively: "This bitmap is recording guest writes, and is allowed to do so." In many places, this is how this predicate was already used. We'll allow users to call user_locked if