Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-30 Thread Daniel P . Berrangé
On Sat, Apr 28, 2018 at 12:16:36PM +0800, 858585 jemmy wrote: > On Fri, Apr 27, 2018 at 5:16 PM, Daniel P. Berrangé > wrote: > so I prefer to add a lock for QEMUFile struct, like this: > > int qemu_fclose(QEMUFile *f) > { > int ret; > qemu_fflush(f); > ret =

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-27 Thread 858585 jemmy
On Fri, Apr 27, 2018 at 5:16 PM, Daniel P. Berrangé wrote: > On Fri, Apr 27, 2018 at 03:56:38PM +0800, 858585 jemmy wrote: >> On Fri, Apr 27, 2018 at 1:36 AM, Dr. David Alan Gilbert >> wrote: >> > * Lidong Chen (jemmy858...@gmail.com) wrote: >> >> This

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-27 Thread Daniel P . Berrangé
On Fri, Apr 27, 2018 at 03:56:38PM +0800, 858585 jemmy wrote: > On Fri, Apr 27, 2018 at 1:36 AM, Dr. David Alan Gilbert > wrote: > > * Lidong Chen (jemmy858...@gmail.com) wrote: > >> This patch implements bi-directional RDMA QIOChannel. Because different > >> threads may

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-27 Thread 858585 jemmy
On Fri, Apr 27, 2018 at 1:36 AM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> This patch implements bi-directional RDMA QIOChannel. Because different >> threads may access RDMAQIOChannel concurrently, this patch use RCU to >> protect it. >>

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-26 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > This patch implements bi-directional RDMA QIOChannel. Because different > threads may access RDMAQIOChannel concurrently, this patch use RCU to protect > it. > > Signed-off-by: Lidong Chen I'm a bit confused by this. I can

[Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

2018-04-25 Thread Lidong Chen
This patch implements bi-directional RDMA QIOChannel. Because different threads may access RDMAQIOChannel concurrently, this patch use RCU to protect it. Signed-off-by: Lidong Chen --- migration/rdma.c | 162 +-- 1