Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-25 Thread Kevin Wolf
Am 24.06.2019 um 18:55 hat Andrey Shinkevich geschrieben: > > > On 17/06/2019 14:45, Kevin Wolf wrote: > > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > >> The Valgrind tool reports about an uninitialised memory usage when the > >> initialization is actually not needed. For example,

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-24 Thread Andrey Shinkevich
On 24/06/2019 20:09, Eric Blake wrote: > On 6/24/19 11:55 AM, Andrey Shinkevich wrote: > +++ b/tests/qemu-iotests/common.rc @@ -17,6 +17,8 @@ # along with this program. If not, see . # +readonly VALGRIND_SUPPRESS_ERRORS=./

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-24 Thread Eric Blake
On 6/24/19 11:55 AM, Andrey Shinkevich wrote: >>> +++ b/tests/qemu-iotests/common.rc >>> @@ -17,6 +17,8 @@ >>># along with this program. If not, see . >>># >>> >>> +readonly VALGRIND_SUPPRESS_ERRORS=./valgrind.supp >> >> Why readonly? >> >> I think it sho

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-24 Thread Andrey Shinkevich
On 13/06/2019 13:06, Vladimir Sementsov-Ogievskiy wrote: > 11.06.2019 21:02, Andrey Shinkevich wrote: >> The Valgrind tool reports about an uninitialised memory usage when the >> initialization is actually not needed. For example, the buffer 'buf' >> instantiated on a stack of the function guess_

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-24 Thread Andrey Shinkevich
On 17/06/2019 14:45, Kevin Wolf wrote: > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: >> The Valgrind tool reports about an uninitialised memory usage when the >> initialization is actually not needed. For example, the buffer 'buf' >> instantiated on a stack of the function guess_dis

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-17 Thread Kevin Wolf
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > The Valgrind tool reports about an uninitialised memory usage when the > initialization is actually not needed. For example, the buffer 'buf' > instantiated on a stack of the function guess_disk_lchs(). I would be careful with calling ini

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-13 Thread Vladimir Sementsov-Ogievskiy
11.06.2019 21:02, Andrey Shinkevich wrote: > The Valgrind tool reports about an uninitialised memory usage when the > initialization is actually not needed. For example, the buffer 'buf' > instantiated on a stack of the function guess_disk_lchs(). for convinience, you may add: "of the function gue

[Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-11 Thread Andrey Shinkevich
The Valgrind tool reports about an uninitialised memory usage when the initialization is actually not needed. For example, the buffer 'buf' instantiated on a stack of the function guess_disk_lchs(). Let's use the Valgrind technology to suppress the unwanted reports by adding the Valgrind specific f